Infobar Close (X) button needs highlight state |
|||||
Issue descriptionFrom pschaffner ( issue 843571 comment 10): Close button highlight (pressed) state: assuming this is a UIButton, set its type to UIButtonTypeSystem to get the standard treatment (this is consistent with the toolbar button highlight states: https://bugs.chromium.org/p/chromium/issues/detail?id=807778#c12); if it isn't a UIButton, or if doing so causes too many weird side-effects, setting the view's alpha property to 0.5 should suffice.
,
Aug 7
Moving infobar bugs into M70.
,
Aug 21
Changed to UIButtonTypeSystem. See screen capture: https://drive.google.com/file/d/11BC50UhNhyXsTTSOSZ5pdEX9qemQ3Pak/view?usp=sharing
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a718f913989a433a48ec58b033b6a49bb0777788 commit a718f913989a433a48ec58b033b6a49bb0777788 Author: Peter K. Lee <pkl@chromium.org> Date: Tue Aug 21 14:54:16 2018 Changed button type to UIButtonTypeSystem to get default treatment This gives the image button a pressed state provided by the system. Bug: 848879 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8912e4cf438a57f27bf432ccb0b1bec10146672c Reviewed-on: https://chromium-review.googlesource.com/1182669 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#584741} [modify] https://crrev.com/a718f913989a433a48ec58b033b6a49bb0777788/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm [modify] https://crrev.com/a718f913989a433a48ec58b033b6a49bb0777788/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
,
Aug 21
,
Oct 1
Issue verified Version: Chrome Beta 70.0.3538.40 Device: iPhone X iOS: 12.0 Correct Highlighted effect on close button https://drive.google.com/open?id=1Ho3H3-J8opvJq39UbbB8pLVJEktaZlf1 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by marq@chromium.org
, Jun 27 2018