Legacy engine bug causes test problem: Auto-sized orthogonal writing mode block gets incorrect size if pushed down by float |
||
Issue descriptionThis is a bug in our legacy layout engine, while it behaves correctly in NG. Because of this difference, the test fast/text-autosizing/clusters-insufficient-text.html won't render correctly in NG, even if we add support for text autosizing. This bug is about fixing that test so that it doesn't depend on the legacy bug. This bug is NOT about fixing the legacy engine.
,
Jun 1 2018
Rendering with the legacy engine
,
Jun 1 2018
The current rendering in NG doesn't do what the test intended for, but the test and the ref match, so it still passes. However, this will no longer be the case once we add support for text-autosizing in NG.
,
Jun 5 2018
This CL will break the test in question (for NG): https://chromium-review.googlesource.com/c/chromium/src/+/1083191
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95047205a9c7e6ad59b0d6478f7e4142f307802b commit 95047205a9c7e6ad59b0d6478f7e4142f307802b Author: Morten Stenshorne <mstensho@chromium.org> Date: Tue Jun 05 20:14:25 2018 Don't depend on buggy behavior for fast/text-autosizing/clusters-insufficient-text.html The legacy layout engine has a bug that's not present in LayoutNG, making it impossible for LayoutNG to pass fast/text-autosizing/clusters-insufficient-text.html . The bug: If a new formatting context in-flow block-level object gets pushed down by a float, strange things happen in legacy layout if this object is a writing mode root. Rather than using the initial containing block as guidance for its inline size, it behaves as if inline-size were set to min-content. So just specify height (inline-size) as min-content in the test, to get identical behavior in the legacy engine and LayoutNG. Bug: 848874 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5928318f17ad3105350bd38d3b81cbe5c35819d0 Reviewed-on: https://chromium-review.googlesource.com/1086996 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#564636} [modify] https://crrev.com/95047205a9c7e6ad59b0d6478f7e4142f307802b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/95047205a9c7e6ad59b0d6478f7e4142f307802b/third_party/WebKit/LayoutTests/fast/text-autosizing/clusters-insufficient-text-expected.html [modify] https://crrev.com/95047205a9c7e6ad59b0d6478f7e4142f307802b/third_party/WebKit/LayoutTests/fast/text-autosizing/clusters-insufficient-text.html
,
Jun 5 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mstensho@chromium.org
, Jun 1 201842.6 KB
42.6 KB View Download