New issue
Advanced search Search tips

Issue 848872 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Pending build requests should show a build number

Project Member Reported by cbiesinger@google.com, Jun 1 2018

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_layout_tests_layout_ng

Would be nice if the "Pending build requests" had the build number too, to more easily identify which one of them is my build I'm waiting for
 
Components: -Infra>Platform>Milo Infra>Platform>Milo>LUCI
Seems like a good idea.  For buildbot builds this wouldn't make sense since build requests and builds don't have 1:1 correspondence.  But we can definitely do this in luci.

Comment 2 by no...@chromium.org, Jun 1 2018

do we really need such a strong distinction in how present pending, started and completed builds? it was necessary in buildbot because one could not get a URL of a pending build, but Milo does not have this limitation. Can we have something like https://luci-ui.appspot.com/p/chromium/buckets/try/builders/linux_chromium_rel_ng
Oh, that's a nice ui! Maybe we should link to that by default
Incomplete + Complete seems okay at first glance, but if there are a lot of builds on one section, it can crowd out builds in another section.  I think the strong distinction between the different states is at least somewhat important, and shows a more complete view of the current state of the builder than otherwise.

Comment 5 by no...@chromium.org, Jun 1 2018

note that we cap number of incomplete builds that we fetch, so they won't hide all of them. We could put builds of different states in collapsable panels if one panel is too large. My point is not necessarily put them in one table, but display them the same way. Currently completed builds are displayed as rows of table, but other builds are displayed as list items. Why different?
They're displayed differently since I wanted to keep the UI consistent while we migrate to luci.  Keeping things consistent through a migration was important for familiarity.

But otherwise, displaying pending/running/completed builds the same way sgtm.
Status: Available (was: Untriaged)
Labels: -Type-Bug Type-Feature
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/82e1430598eac01c36a9fdb716e18a9795d8d703

commit 82e1430598eac01c36a9fdb716e18a9795d8d703
Author: Ryan Tseng <hinoka@google.com>
Date: Mon Nov 26 22:31:15 2018

[milo] Add build links for pending builds

This adds build numbers and links for luci builds and is a no-op for buildbot builds.

Bug: 848872
Change-Id: Ib68ea1625f2a191bf376776067f2d83113c1185f
Reviewed-on: https://chromium-review.googlesource.com/c/1351550
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/82e1430598eac01c36a9fdb716e18a9795d8d703/milo/frontend/appengine/templates/pages/builder.html
[modify] https://crrev.com/82e1430598eac01c36a9fdb716e18a9795d8d703/milo/frontend/expectations/buildbot.builder-Basic_Test_with_builds.html

Sign in to add a comment