New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848864 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

chrome://proximity-auth doesn't work

Project Member Reported by khorimoto@chromium.org, Jun 1 2018

Issue description

On ToT.

(1) Load chrome://proximity-auth.
(2) Nothing loads.

"Uncaught TypeError: chrome.send is not a function"
 
Owner: hansberry@chromium.org
Status: Assigned (was: Available)
Ryan, can you look at this for now?
Status: Started (was: Assigned)
This was caused by https://chromium-review.googlesource.com/c/chromium/src/+/1025673. Investigating solutions.
Owner: khorimoto@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2bc3ea599274718045aea77cfe54718f17f5132

commit d2bc3ea599274718045aea77cfe54718f17f5132
Author: Kyle Horimoto <khorimoto@google.com>
Date: Fri Jun 01 20:52:24 2018

[CrOS MultiDevice] Fix broken chrome://proximity-auth WebUI.

This debug UI was broken by a recent refactor:
https://chromium-review.googlesource.com/c/chromium/src/+/1025673.

This CL adds the ability to run chrome.send() back to the page.

TBR=hansberry

Bug:  848864 
Change-Id: I380d3431a2813851acaccb8676aba04bc60a2408
Reviewed-on: https://chromium-review.googlesource.com/1083121
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563788}
[modify] https://crrev.com/d2bc3ea599274718045aea77cfe54718f17f5132/chromeos/components/proximity_auth/webui/proximity_auth_ui.cc

Status: Fixed (was: Started)

Sign in to add a comment