New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848850 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 847604
Owner:
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Viz hit test: do not query client if target has no child.

Project Member Reported by sunxd@chromium.org, Jun 1 2018

Issue description

If we encounter a kHitTestAsk flag, we do async hit testing by asking each potential target views. This is not necessary if the target view does not contain any nested child views. We can directly dispatch the event under this circumstance.
 
Cc: kenrb@chromium.org
Is this the same as issue 847604?

Comment 2 by kenrb@chromium.org, Jun 2 2018

Mergedinto: 847604
Status: Duplicate (was: Started)
Yes, I have a CL up that tries to do this, although it looks like I still have to address some test flakiness: https://chromium-review.googlesource.com/c/chromium/src/+/1081387

Comment 3 by kenrb@chromium.org, Jun 2 2018

Status: Started (was: Duplicate)
Okay I just noticed you have put up a CL also, although it takes a different approach. I think it's better to do another synchronous hit test, since it lets us avoid the extra round trip if there is an embedded OOPIF that is not under the mouse cursor.
Hi Ken, are you working on issue 847604 right now?
I was planning on getting it back to it soon, because I've been sidetracked by bugs for a while. I have two CLs in progress that I need to land first.

My CL stopped progressing because it is harder than I expected to do a hit test starting from an arbitrary HitTestRegion (i.e. not the root). With Surface hit testing it was pretty easy but that is less relevant because it will be going away soon.
Got that, shall we merge this back to issue 847604 then?
Status: Duplicate (was: Started)

Sign in to add a comment