New issue
Advanced search Search tips

Issue 848844 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 1
Type: Bug

Blocking:
issue 841758



Sign in to add a comment

Remove "No, Thanks" button from the non-Gpay credit card save infobars on mobile

Project Member Reported by mahmadi@chromium.org, Jun 1 2018

Issue description

This makes the save card infobars consistent with one another.   
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018

Labels: Merge-Request-68
Status: Fixed (was: Started)
Verified on Chrome Canary 69.0.3452.0

Project Member

Comment 3 by sheriffbot@chromium.org, Jun 7 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211a88a359686226c4d3b798896385abe9101d0d

commit 211a88a359686226c4d3b798896385abe9101d0d
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Jun 07 18:23:14 2018

[AF] Removes "No, Thanks" button from non-Gpay CC save infobars on mobile

Bug:  848844 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If99ca67b17829cea6cc68491e9db5fcf4b1099d8
Reviewed-on: https://chromium-review.googlesource.com/1082956
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564113}(cherry picked from commit 9a3239b7cad48dbc42cd6a66e43749b4e0eb0580)
Reviewed-on: https://chromium-review.googlesource.com/1091174
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#241}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/211a88a359686226c4d3b798896385abe9101d0d/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/211a88a359686226c4d3b798896385abe9101d0d/chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc
[modify] https://crrev.com/211a88a359686226c4d3b798896385abe9101d0d/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/211a88a359686226c4d3b798896385abe9101d0d/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/211a88a359686226c4d3b798896385abe9101d0d/ios/chrome/browser/ui/autofill/save_card_infobar_controller.mm

Blocking: 841758
Status: Verified (was: Fixed)
Verified in 69.0.3455.0 Canary on iPhone 8plus(iOS 11.4) and iPad Pro(iOS 10.3.3)

Followed the steps below:
1. Load https://rsolomakhin.github.io/autofill
2. Go to Credit card autofill form
3. Tap on "CC Fill Form(Superman)" and tap on submit button

"No thanks" button is not display in CC save infobar 

Link to screenshot:
https://drive.google.com/file/d/1Lnu5bb4gcPvmY3QkK5SQeQoELP98aa5x/view?usp=sharing

Verified in 68.0.3440.23 Beta on iPhone 8plus(iOS 11.4) and iPad Pro(iOS 10.3.3)

"No thanks" button is not display in CC save infobar 

Sign in to add a comment