Remove "Learn More" links from the credit card local save infobars on mobile |
|||||||
Issue descriptionLearn more link is not valuable, not visually appealing and can lead to extra drop-off rate.
,
Jun 2 2018
Moe, I think your change covers both Android and iOS, let me know if it is not the case. I can change in Android.
,
Jun 2 2018
What about desktop change here ?
,
Jun 2 2018
Yes, it does affect both. I tested it on Android and iOS and both are fixed. I'm not sure if "learn more" on Desktop is as problematic. rfeng@, wdyt?
,
Jun 4 2018
Verified on Chrome Canary 69.0.3449.0
,
Jun 5 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6334ffcbe9ee185ff2cdc6cfca8fe5fe1dcfd083 commit 6334ffcbe9ee185ff2cdc6cfca8fe5fe1dcfd083 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Jun 06 17:08:43 2018 [AF] Removes "Learn More" link from credit card save infobars on mobile Bug: 848841 Change-Id: Iebef5c799aa6bcd018a89d57389deffbe42c85b2 Reviewed-on: https://chromium-review.googlesource.com/1082971 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563860}(cherry picked from commit 16da6828a42b4fde85fcf986a6a642bb6170b6fd) Reviewed-on: https://chromium-review.googlesource.com/1089230 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#212} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/6334ffcbe9ee185ff2cdc6cfca8fe5fe1dcfd083/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc [modify] https://crrev.com/6334ffcbe9ee185ff2cdc6cfca8fe5fe1dcfd083/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
,
Jun 7 2018
,
Jul 9
Verified in 68.0.3440.56 Beta in iPhone7(iOS 11.4), iPad (iOS 11.4) Followed the below steps 1. Enable 'offers uploading Autofilled credit cards' and 'Enable updated prompt explanation when offering credit card upload' in chrome://flags 2. Go to https://rsolomakhin.github.io/autofill 3. Go to Credit card autofill and tap on button 'CC Fill Form(president)' 4. Tap on submit button Observed result: In Credit card local save infobar the learn button is not displayed Link to screenshot: https://drive.google.com/file/d/1aMq36bKswmMGxAoxL9Q0qB2pHMv-k_nh/view?usp=sharing |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2018