New issue
Advanced search Search tips

Issue 848841 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 1
Type: Bug

Blocking:
issue 841758



Sign in to add a comment

Remove "Learn More" links from the credit card local save infobars on mobile

Project Member Reported by mahmadi@chromium.org, Jun 1 2018

Issue description

Learn more link is not valuable, not visually appealing and can lead to extra drop-off rate.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16da6828a42b4fde85fcf986a6a642bb6170b6fd

commit 16da6828a42b4fde85fcf986a6a642bb6170b6fd
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Jun 01 23:29:07 2018

[AF] Removes "Learn More" link from credit card save infobars on mobile

Bug:  848841 
Change-Id: Iebef5c799aa6bcd018a89d57389deffbe42c85b2
Reviewed-on: https://chromium-review.googlesource.com/1082971
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563860}
[modify] https://crrev.com/16da6828a42b4fde85fcf986a6a642bb6170b6fd/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/16da6828a42b4fde85fcf986a6a642bb6170b6fd/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h

Comment 2 by dlkumar@google.com, Jun 2 2018

Moe, I think your change covers both Android and iOS, let me know if it is not the case. I can change in Android. 

Comment 3 by dlkumar@google.com, Jun 2 2018

What about desktop change here ?
Status: Fixed (was: Started)
Yes, it does affect both. I tested it on Android and iOS and both are fixed. I'm not sure if "learn more" on Desktop is as problematic. rfeng@, wdyt?
Screen Shot 2018-06-01 at 8.47.29 PM.png
35.3 KB View Download
Labels: Merge-Request-68
Verified on Chrome Canary 69.0.3449.0
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 5 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6334ffcbe9ee185ff2cdc6cfca8fe5fe1dcfd083

commit 6334ffcbe9ee185ff2cdc6cfca8fe5fe1dcfd083
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Jun 06 17:08:43 2018

[AF] Removes "Learn More" link from credit card save infobars on mobile

Bug:  848841 
Change-Id: Iebef5c799aa6bcd018a89d57389deffbe42c85b2
Reviewed-on: https://chromium-review.googlesource.com/1082971
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563860}(cherry picked from commit 16da6828a42b4fde85fcf986a6a642bb6170b6fd)
Reviewed-on: https://chromium-review.googlesource.com/1089230
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#212}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/6334ffcbe9ee185ff2cdc6cfca8fe5fe1dcfd083/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/6334ffcbe9ee185ff2cdc6cfca8fe5fe1dcfd083/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h

Blocking: 841758
Status: Verified (was: Fixed)
Verified in 68.0.3440.56 Beta in iPhone7(iOS 11.4), iPad (iOS 11.4)

Followed the below steps

1. Enable 'offers uploading Autofilled credit cards' and 'Enable updated prompt explanation when offering credit card upload' in chrome://flags
2. Go to https://rsolomakhin.github.io/autofill
3. Go to Credit card autofill and tap on button 'CC Fill Form(president)'
4. Tap on submit button

Observed result:
In Credit card local save infobar the learn button is not displayed

Link to screenshot:

https://drive.google.com/file/d/1aMq36bKswmMGxAoxL9Q0qB2pHMv-k_nh/view?usp=sharing

Sign in to add a comment