PrefetchURLLoaderService does not support file URLs with the network service |
|||
Issue descriptionSeveral prefetch layout tests fail when file access is disabled in the network service: fast/dom/HTMLLinkElement/link-and-subresource-test.html fast/dom/HTMLLinkElement/prefetch-onload.html fast/dom/HTMLLinkElement/prefetch.html fast/dom/HTMLLinkElement/subresource.html The problem is when a page loaded over a file URL does a prefetch of a file URL, it fails because the PrefetchURLLoaderService does not have a FileURLLoaderFactory.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3492f24eeb286d5a1f10a00e238562bfa7e4c09f commit 3492f24eeb286d5a1f10a00e238562bfa7e4c09f Author: Kinuko Yasuda <kinuko@chromium.org> Date: Mon Jun 04 10:49:43 2018 Clone and pass RenderFrameImpl's subresource loader factories to Prefetch So that the browser-side prefetch code can also fetch things from file: or from all other schemes. (While: it doesn't look it's too useful to prefetch non-network files) Verified that applying review.googlesource.com/c/chromium/src/+/1045313 then run the fast/dom/HTMLLinkElement/prefetch.html layout test let it succeed. Change-Id: Id026b7fe6aebb479a8ac0c81a730840900bc7c5b Bug: 848831 Reviewed-on: https://chromium-review.googlesource.com/1082260 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#564049} [modify] https://crrev.com/3492f24eeb286d5a1f10a00e238562bfa7e4c09f/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/3492f24eeb286d5a1f10a00e238562bfa7e4c09f/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/3492f24eeb286d5a1f10a00e238562bfa7e4c09f/content/browser/loader/prefetch_url_loader_service.cc [modify] https://crrev.com/3492f24eeb286d5a1f10a00e238562bfa7e4c09f/content/browser/loader/prefetch_url_loader_service.h [modify] https://crrev.com/3492f24eeb286d5a1f10a00e238562bfa7e4c09f/content/browser/storage_partition_impl.cc
,
Jun 6 2018
,
Jun 6 2018
Fixed, I think. |
|||
►
Sign in to add a comment |
|||
Comment 1 by kinuko@chromium.org
, Jun 4 2018Status: Assigned (was: Available)