New issue
Advanced search Search tips

Issue 848823 link

Starred by 1 user
Status: Fixed
Owner:
alph@chromium.org
Closed: Dec 18
Cc:
einbinder@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Developer tools console doesn't execute scripts which contain some special unicode characters

Reported by hakerh403@gmail.com, Jun 1 2018 
UserAgent: Mozilla/5.0 (ws NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36

Steps to reproduce the problem:
1. Open devtools console
2. Write this code: '􏿿'==='\u{10FFFF}'
3. Press enter

What is the expected behavior?
The code should be evaluated to `true`

What went wrong?
Nothing happens. The issue is not seen in Firefox.

Did this work before? N/A 

Chrome version: see user agent  Channel: stable
OS Version: 6.3
Flash Version: /

Comment 1 by krajshree@chromium.org, Jun 3 2018

Labels: Needs-Triage-M66

Comment 2 by krajshree@chromium.org, Jun 4 2018

Labels: Triaged-ET M-69 Target-69 FoundIn-69 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.13.3, Win-10 and Ubuntu 17.10 using chrome latest stable #67.0.3396.62 and latest canary #69.0.3449.0.
This is a non-regression issue as it is observed from M60 old builds. 

Hence, marking it as untriaged to get more inputs from dev team.

Thanks...!!

Comment 3 by kozy@chromium.org, Jun 4 2018

Cc: einbinder@chromium.org
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by l...@chromium.org, Nov 16

Owner: alph@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbceff0742292e009f941f2e7bcfb56d42d34324

commit bbceff0742292e009f941f2e7bcfb56d42d34324
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Dec 17 23:40:28 2018

DevTools: Escape invalid Unicode characters for Runtime.execute

JSON does not support invalid Unicode characters such as U+10FFFF, or orphane
surrogates, although JavaScript allows them inside strings. Make sure the invalid
characters are properly escaped before packing them into the protocol JSON.

BUG= 848823 

Change-Id: I870b45ee78d0aa9b8229e59cbf7d02e8e56ec6f6
Reviewed-on: https://chromium-review.googlesource.com/c/1352588
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617286}
[modify] https://crrev.com/bbceff0742292e009f941f2e7bcfb56d42d34324/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/bbceff0742292e009f941f2e7bcfb56d42d34324/third_party/blink/renderer/devtools/front_end/sdk/RuntimeModel.js
[add] https://crrev.com/bbceff0742292e009f941f2e7bcfb56d42d34324/third_party/blink/web_tests/http/tests/devtools/runtime/runtime-evaluate-bad-unicode-expected.txt
[add] https://crrev.com/bbceff0742292e009f941f2e7bcfb56d42d34324/third_party/blink/web_tests/http/tests/devtools/runtime/runtime-evaluate-bad-unicode.js

Comment 6 by alph@chromium.org, Dec 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment