There is extra spacing under the close button in the credit card save infobar |
|||||||
Issue descriptionThis spacing should not exist and the content should flow under the close button within the infobar padding.
,
Jun 7 2018
,
Jun 8 2018
Verified the fix on Chrome iOS Canary 69.0.3453.0
,
Jun 8 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 11 2018
This is a big change. Test team can you also verify this is fixed?
,
Jun 11 2018
Please see comment #3. I verified the fix on Canary 69.0.3453.0 already.
,
Jun 12 2018
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7aea38c9c9c0313b560bf3556f71683aa3cc51e9 commit 7aea38c9c9c0313b560bf3556f71683aa3cc51e9 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Jun 12 19:40:34 2018 [AF][IOS] Removes extra spacing below the close button in CC save infobar Adds more comments and ascii visuals for improved readablity Bug: 848820 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I361b1bf51c7d5dd09fc51374a8604b0d67f83c38 Reviewed-on: https://chromium-review.googlesource.com/1082927 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#565181}(cherry picked from commit 9aac2244fec338fc40c19994a1ae096032e703f5) Reviewed-on: https://chromium-review.googlesource.com/1097659 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#309} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/7aea38c9c9c0313b560bf3556f71683aa3cc51e9/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
,
Jun 20 2018
Verified in 68.0.3440.30 Beta on iPhone 7plus(iOS 10.3.3), iPhone 8plus(iOS 11.4) and iPad Air(iOS 10.3.3) No extra space under close button in credit card info bar, looks good Link to Screenshot: https://drive.google.com/file/d/1dJIvQkp8ULC6y8thHo9Cyv_T3j7FXUuH/view?usp=sharing |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 7 2018