android_optional_gpu_tests_rel trybots don't do anything |
||||
Issue descriptionSee https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_optional_gpu_tests_rel?limit=200 The only failures are 'analyse' failures, but otherwise the bots never even compile anything. It seems like the analyse step always makes it early out. See e.g. https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8944903134510651632%2F%2B%2Fsteps%2Fanalyze%2F0%2Fstdout analyze input: { "additional_compile_targets": [], "files": [ "third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc", "third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h" ], "test_targets": [] } analyze output: { "compile_targets": [], "status": "No dependency", "test_targets": [] } Is the problem that there are no test targets? Should there be?
,
Jun 1 2018
This is working as intended. We recently moved all of the Android GPU tests to the main android_n5x_swarming_rel (now https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel ) tryserver. We eventually will want to run extended tests on android_optional_gpu_tests_rel like the WebGL 2.0 conformance suite, similarly to how the desktop optional trybots work. This is on the to-do list. We didn't want to decommission the android_optional_gpu_tests_rel tryserver just to spin it up again later.
,
Jun 1 2018
Should we remove it from PRESUBMIT.py files then? https://cs.chromium.org/search/?q=android_optional_gpu_tests_rel&type=cs If they don't run anything, there's no point in submitting work to them, and potentially add a failure mode to CLs.
,
Jun 1 2018
Right now there is parity in the various PRESUBMIT.py files between the Android optional GPU trybot and the desktop optional trybots. We aim to add more tests to this trybot soon and I would rather not add the churn of removing it from all of the presubmit files, and then add it back in a few weeks. The analyze failures found by this bot are all legitimate. |
||||
►
Sign in to add a comment |
||||
Comment 1 by piman@chromium.org
, Jun 1 2018