WPT LayoutTests don't wait for font load if reftest-wait is present |
||||
Issue descriptionI just took a look at the commit from issue 507054 (https://chromium.googlesource.com/chromium/src.git/+/835b608d4a69ec7d52d279b4a481419dcba5a4ac), and noticed something that I believe to be different to upstream: upstream *always* waits for document.fonts.ready, regardless of whether reftest-wait is used, which seems like a potential source of flake compared with upstream.
,
Jun 5 2018
robertma@ and I stared at this literally for hours, so that discrepancy seems a bit implausible. Robert, can you check?
,
Jun 5 2018
Re #2: yeah I double checked. We were focusing on other stuff, but didn't really pay attention to the upstream injected script. https://github.com/web-platform-tests/wpt/blob/master/tools/wptrunner/wptrunner/executors/reftest-wait_webdriver.js ready_for_screenshot is called in both cases, which does the double rAF thing inside. gsnedders@ has sent a CL https://chromium-review.googlesource.com/c/chromium/src/+/1082319 and I've LGTM'ed.
,
Jun 5 2018
Now I remember that we wanted this behavior in order to be able to test don't loading timing itself, perhaps with slow-loading fonts. And that we were going to propose the same change upstream if it worked out. But we didn't do those things.
,
Jun 6 2018
Confirming that discrepancy is real at least :)
,
Aug 2
,
Aug 20
@foolip: did you ever start any discussion about this upstream?
,
Aug 31
Oh, we have https://github.com/web-platform-tests/wpt/issues/11476 for this.
,
Aug 31
|
||||
►
Sign in to add a comment |
||||
Comment 1 by geoff...@gmail.com
, Jun 1 2018