Cookies are not getting deleted on shutdown when a policy is set.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/385b5a513973242975ba68b28041aef8c21d9cc9 commit 385b5a513973242975ba68b28041aef8c21d9cc9 Author: Clark DuVall <cduvall@chromium.org> Date: Thu Jun 14 21:33:32 2018 Handle deleting cookies with session-only policy in network service The ContentSettings for cookies are now synced to the network service, which allows us to delete cookies properly when the session ends. SessionCleanupCookieStore and tests are mostly moved over from QuotaPolicyCookieStore. Bug: 848801 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I53f8d7f6cb6439d3b39fad22c406bf058b758e52 Reviewed-on: https://chromium-review.googlesource.com/1090035 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#567428} [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/chrome/browser/extensions/DEPS [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/chrome/browser/extensions/extension_special_storage_policy.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/chrome/browser/extensions/extension_special_storage_policy.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/chrome/browser/extensions/mock_extension_special_storage_policy.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/chrome/browser/extensions/mock_extension_special_storage_policy.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/chrome/browser/profiles/profile_impl.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/components/content_settings/core/browser/cookie_settings.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/components/content_settings/core/browser/cookie_settings.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/components/content_settings/core/common/BUILD.gn [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/components/content_settings/core/common/DEPS [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/components/content_settings/core/common/cookie_settings_base.cc [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/components/content_settings/core/common/cookie_settings_base.h [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/components/content_settings/core/common/cookie_settings_base_unittest.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/content/browser/browser_context.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/content/browser/net/quota_policy_cookie_store.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/content/browser/net/quota_policy_cookie_store.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/extensions/shell/browser/DEPS [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/extensions/shell/browser/shell_special_storage_policy.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/extensions/shell/browser/shell_special_storage_policy.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/BUILD.gn [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/DEPS [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/cookie_manager.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/cookie_manager.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/cookie_manager_unittest.cc [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/cookie_settings.cc [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/cookie_settings.h [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/cookie_settings_unittest.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/network_context.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/network_context.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/public/mojom/BUILD.gn [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/public/mojom/cookie_manager.mojom [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/session_cleanup_cookie_store.cc [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/session_cleanup_cookie_store.h [add] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/services/network/session_cleanup_cookie_store_unittest.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/storage/DEPS [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/storage/browser/BUILD.gn [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/storage/browser/quota/special_storage_policy.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/storage/browser/test/mock_special_storage_policy.cc [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/storage/browser/test/mock_special_storage_policy.h [modify] https://crrev.com/385b5a513973242975ba68b28041aef8c21d9cc9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Comment 1 by cduvall@chromium.org
, Jun 1 2018