New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848788 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

[VR Browsing] button "use the app" on Infobar to edit Google Doc does nothing.

Project Member Reported by dbbrooks@chromium.org, Jun 1 2018

Issue description

Chrome Version: 68.0.3440.7
OS: Android 8
Device: Pixel, any phones, AIO devices. Any Daydream supported device.

What steps will reproduce the problem?
(1) Open a Google Doc in Chrome VR.
(2) Click on the edit icon on the upper right.
(3) An Infobar appears saying "Edit with the Sheets app" with 2 buttons: "no thanks" and "use the app".
(4) Click on the "use the app" button.

What is the expected result? Something. E.g. DOFF to Google Drive app.

What happens instead? Nothing. Users can keep clicking the "use the app" button to their heart's content, but nothing will happen.

 
Screenshot_20180601-091440.png
348 KB View Download
Owner: bshe@chromium.org
Status: Assigned (was: Untriaged)
Assigned to bshe@
Feel free to assign it back to me if you don't have time for it
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ddf3b0fb2c523c5e3d5e2e6876bf3cddac691e6

commit 3ddf3b0fb2c523c5e3d5e2e6876bf3cddac691e6
Author: Biao She <bshe@chromium.org>
Date: Wed Jun 06 14:52:25 2018

Fix handling of navigation to external app

Previously, we want all redirection stays in Chrome while in VR. The problem is
if a webpage sends a redirection request that Chrome can't navigate to
(i.e. intent://*). Chrome just silently block the request. This leads to problem
described in  issue 848788 .
This CL unblocks such redirection (when redirect to an external app).

Bug:  848788 
Change-Id: Ia1fc66afe1d011d1c814f7a907d423f053e7fb28
Reviewed-on: https://chromium-review.googlesource.com/1087775
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564889}
[modify] https://crrev.com/3ddf3b0fb2c523c5e3d5e2e6876bf3cddac691e6/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Comment 3 by bshe@chromium.org, Jun 6 2018

Status: Fixed (was: Assigned)

Sign in to add a comment