Remove "LUCI" chip |
|||||||
Issue descriptionNow that most of chromium is on LUCI, replace LUCI chips in buildbucket-gerrit plugin with a buidlbot chip (on buildbot builds)
,
Jun 1 2018
I think that's what comment 0 suggests too.
,
Jun 1 2018
efoo volunteered
,
Jun 13 2018
I think we can remove it altogether. The problem it used to solve no longer exists. We were worried that if a build fails because of LUCI, users may want to know, e.g. correlated failure with LUCI chip presence and opt-out. This is no longer relevant. Removing this will reduce code complexity.
,
Jun 22 2018
,
Jun 22 2018
,
Sep 17
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/98c6a9d81d6af50ef62b3401122b815f41eef398 commit 98c6a9d81d6af50ef62b3401122b815f41eef398 Author: Nodir Turakulov <nodir@google.com> Date: Mon Sep 17 23:22:00 2018 [buildbucket] Display Buildbot chip. Most of builds are on LUCI now. Replace LUCI chip with orange Buildbot chip. Bug: 848787 Change-Id: Iec07d780905e2db3d60500adb1f6632540f1533b Reviewed-on: https://chromium-review.googlesource.com/1228429 Reviewed-by: Erik Staab <estaab@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/98c6a9d81d6af50ef62b3401122b815f41eef398/src/main/resources/static/cr-build-block.html [modify] https://crrev.com/98c6a9d81d6af50ef62b3401122b815f41eef398/src/main/resources/static/cr-build-block.js [modify] https://crrev.com/98c6a9d81d6af50ef62b3401122b815f41eef398/test/cr-build-block_test.html [modify] https://crrev.com/98c6a9d81d6af50ef62b3401122b815f41eef398/src/main/resources/static/cr-buildbucket-view.html [modify] https://crrev.com/98c6a9d81d6af50ef62b3401122b815f41eef398/src/main/resources/static/cr-buildbucket-view.js [modify] https://crrev.com/98c6a9d81d6af50ef62b3401122b815f41eef398/test/cr-buildbucket-view_test.html
,
Sep 19
deployed
,
Sep 19
Thanks! Much less noisy :-)
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/40721ae447dd3509445322c521df65885fd99279 commit 40721ae447dd3509445322c521df65885fd99279 Author: Eric Foo <efoo@chromium.org> Date: Mon Sep 24 19:35:11 2018 Update info on gerrit tryjobs on LUCI/Buildbot Bug: 848787 Change-Id: I7283eea0de68d6f795b74b8159ca62588e226fb8 Reviewed-on: https://chromium-review.googlesource.com/1239568 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#17833} [modify] https://crrev.com/40721ae447dd3509445322c521df65885fd99279/doc/users/services/about_luci.md [modify] https://crrev.com/40721ae447dd3509445322c521df65885fd99279/doc/images/luci_chip.png |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by efoo@chromium.org
, Jun 1 2018