[MD-Refresh] macOS: Regression: InkDrop Animations are appearing |
|||||
Issue descriptionChrome Version: Canary 69.0.3447.2 OS: macOS 10.12.x What steps will reproduce the problem? (1) Click on any Toolbar icon Bookmarks, Extensions, etc (except Omnibox icons) (2) (3) What is the expected result? No InkDrop Animation. What happens instead? InkDrop animation appears. Regression Range: https://chromium.googlesource.com/chromium/src/+log/41066e83216ea19036dcf33cfbf35e18f77da9fe..69dce9db81170f487527b21f13772f9f555726d8 pbos@: I think this is a side-effect of https://chromium-review.googlesource.com/1080552 Not sure if this was intended or not. I remember to read somewhere that the animations should not appear on macOS, right? Thanks for looking at this issue in advance. Mehmet
,
Jun 1 2018
+ellyjones@ I think I enabled all Touchable inkdrop fuzz for Refresh as well, which obviously hits Mac equally (and would if Mac Touchable was ever turned on). Is this undesired? If so do you have any idea how we can disable flood-fill in one swoop instead of tracking all of them down individually?
,
Jun 5 2018
#2: I don't - in the past I've tried and failed to do just that. I do not understand the ink drop code. The ink drop layer is used for effects we do want on Mac, like the hover effect, but we do not want the flood-fill effect.
,
Jun 5 2018
Per out-of-band discussion I'll investigate making the floodfill effect instant on Mac so we get the same active shades.
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a3a8cbad733c5c716c97cff2636319a2522738c commit 3a3a8cbad733c5c716c97cff2636319a2522738c Author: Peter Boström <pbos@chromium.org> Date: Wed Jun 06 17:27:31 2018 Instantly animate ink-drop-ripple effects for Mac Instead of using a fully transparent ripple on Mac, this uses the same active-ripple effect as other platforms, but instantly animates to them. This effectively makes use of the active color in the ripple effect but without using the animation (flood-fill effect). This fixes a recent regression where MacViews + Refresh got ink-drop ripples on toolbar and bookmark buttons. It also effectively adds active-state color that was missing on Mac both for toolbar buttons and secondary UI MdTextButtons. Bug: chromium:848767 Change-Id: Ia28d26c128dff12d2181c4dea41a0d4418a9d47c Reviewed-on: https://chromium-review.googlesource.com/1087949 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#564946} [modify] https://crrev.com/3a3a8cbad733c5c716c97cff2636319a2522738c/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/3a3a8cbad733c5c716c97cff2636319a2522738c/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/3a3a8cbad733c5c716c97cff2636319a2522738c/ui/views/animation/flood_fill_ink_drop_ripple.cc [modify] https://crrev.com/3a3a8cbad733c5c716c97cff2636319a2522738c/ui/views/animation/ink_drop_host_view.cc [modify] https://crrev.com/3a3a8cbad733c5c716c97cff2636319a2522738c/ui/views/animation/square_ink_drop_ripple.cc
,
Jun 6 2018
Thanks mehmet@!
,
Jun 6 2018
Thanks pbos@. Works fine in latest Snapshot #564964 under MDRefresh. The flood-fill effect doesn't appear anymore on the buttons. Instead it adds the active-state color on the button when pressed 👍 But under MacViews-only I am seeing on the Extension-Buttons, on the Back-/Forward arrows, Reload and Home button a round shadow around the button when I press on one of it. It doesn't happen on the Settings Button, Bookmarks and Omnibox Buttons. Here is a screenshot. Not sure if we can live with it.
,
Jun 6 2018
Thanks! We don't care much about MacViews without Refresh so that's fine for now.
,
Jun 6 2018
Okay. Thanks for your feedback and the info :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by meh...@chromium.org
, Jun 1 201832.7 KB
32.7 KB View Download