PageLoadCappingBrowserTest.PageLoadCappingBlocksLoads is flaky |
||
Issue descriptionI'll disable it for now. ryansturm@chromium.org should have a patch later today.
,
Jun 1 2018
Since you are planning a fix soon, I think I'll leave it as is, but I'll keep an eye open :)
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c993da7007e67708101125e57ab57cf771890c4b commit c993da7007e67708101125e57ab57cf771890c4b Author: sebsg <sebsg@chromium.org> Date: Fri Jun 01 15:33:07 2018 Disable PageLoadCappingBrowserTest.PageLoadCappingBlocksLoads. Test is flaky, a fix is on the way. Tbr: ryansturm@chromium.org Bug: 848754 Change-Id: Ie5dab1b35c24057408aa723da0e299f0f1d7b8f4 Reviewed-on: https://chromium-review.googlesource.com/1082591 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#563642} [modify] https://crrev.com/c993da7007e67708101125e57ab57cf771890c4b/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc
,
Jun 1 2018
Adding appropriate field trials (features) should address the problem here. I managed to repro this by disabling two specific features in a chromium build, so enabling them in an official build should fix this issue.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90ace1bf1cefefbc6bf6cf7e1e5aaf509e1d68d0 commit 90ace1bf1cefefbc6bf6cf7e1e5aaf509e1d68d0 Author: Ryan Sturm <ryansturm@chromium.org> Date: Fri Jun 01 17:26:00 2018 Adding features to page load capping browsertest This also re-enables the test that was failing on official builds. This should prevent flakes in the official builds. These are normally on from fieldtrial_testing_config.json for waterfall bots, but official builds do no take field trials from that test file. Bug: 848754 Change-Id: I9e1409613483572eb20eddb5db513abf2d7ec8c3 Reviewed-on: https://chromium-review.googlesource.com/1082658 Reviewed-by: Scott Little <sclittle@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#563701} [modify] https://crrev.com/90ace1bf1cefefbc6bf6cf7e1e5aaf509e1d68d0/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc
,
Jun 1 2018
Issue 848699 has been merged into this issue.
,
Jun 1 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ryansturm@chromium.org
, Jun 1 2018