New issue
Advanced search Search tips

Issue 848754 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PageLoadCappingBrowserTest.PageLoadCappingBlocksLoads is flaky

Project Member Reported by se...@chromium.org, Jun 1 2018

Issue description

I'll disable it for now.

ryansturm@chromium.org should have a patch later today.
 
Thanks! Feel free to disable the others in that newly added file as well. I suspect those could be flaky as well.

Comment 2 by se...@chromium.org, Jun 1 2018

Since you are planning a fix soon, I think I'll leave it as is, but I'll keep an eye open :)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c993da7007e67708101125e57ab57cf771890c4b

commit c993da7007e67708101125e57ab57cf771890c4b
Author: sebsg <sebsg@chromium.org>
Date: Fri Jun 01 15:33:07 2018

Disable PageLoadCappingBrowserTest.PageLoadCappingBlocksLoads.

Test is flaky, a fix is on the way.

Tbr: ryansturm@chromium.org
Bug:  848754 
Change-Id: Ie5dab1b35c24057408aa723da0e299f0f1d7b8f4
Reviewed-on: https://chromium-review.googlesource.com/1082591
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563642}
[modify] https://crrev.com/c993da7007e67708101125e57ab57cf771890c4b/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc

Adding appropriate field trials (features) should address the problem here. I managed to repro this by disabling two specific features in a chromium build, so enabling them in an official build should fix this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90ace1bf1cefefbc6bf6cf7e1e5aaf509e1d68d0

commit 90ace1bf1cefefbc6bf6cf7e1e5aaf509e1d68d0
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Jun 01 17:26:00 2018

Adding features to page load capping browsertest

This also re-enables the test that was failing on official builds.

This should prevent flakes in the official builds. These are normally on
from fieldtrial_testing_config.json for waterfall bots, but official
builds do no take field trials from that test file.

Bug:  848754 
Change-Id: I9e1409613483572eb20eddb5db513abf2d7ec8c3
Reviewed-on: https://chromium-review.googlesource.com/1082658
Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563701}
[modify] https://crrev.com/90ace1bf1cefefbc6bf6cf7e1e5aaf509e1d68d0/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc

Issue 848699 has been merged into this issue.
Status: Fixed (was: Assigned)

Sign in to add a comment