New issue
Advanced search Search tips

Issue 848749 link

Starred by 2 users
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Jun 2018
Cc:
torne@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 841525



Sign in to add a comment

Some java build intermediates are not hermetic

Project Member Reported by agrieve@chromium.org, Jun 1 2018 
The intermediates are:
1) javac output
2) bytecode rewriting
3) desugar
4) filtering

Looking at the unzip -l output of each of these:

1) javac output is unsorted 
2) bytecode rewriting does not zero out timestamps
4) filtering does not maintain the input ordering

Comment 1 by agrieve@chromium.org, Jun 1 2018

Blocking: 841525
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e66639a64b287a9d5bc35d7c42644073a21e881

commit 0e66639a64b287a9d5bc35d7c42644073a21e881
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Jun 05 19:00:34 2018

Android: Make java build steps more hermetic

1) Sort javac output
2) Zero out timestamps in bytecode rewriter
3) Maintain file order for when filtering

TBR=michaelbai  # trivial rename

Bug:  848749 
Change-Id: I6963b57ca7ad7c4d424b55779ea2513d038d7b7b
Reviewed-on: https://chromium-review.googlesource.com/1083094
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564602}
[modify] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/android_webview/tools/apk_merger.py
[modify] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/build/android/bytecode/java/org/chromium/bytecode/ByteCodeProcessor.java
[add] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/build/android/gyp/filter_zip.py
[modify] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/build/android/gyp/jar.py
[modify] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/build/android/gyp/util/build_utils.py
[modify] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/build/android/incremental_install/generate_android_manifest.py
[modify] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/build/config/android/internal_rules.gni
[modify] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerTestBase.java
[modify] https://crrev.com/0e66639a64b287a9d5bc35d7c42644073a21e881/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/CctOfflinePageModelObserverTest.java
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/316181e2c4eb88441a69351fb79607ccc0d99d9a

commit 316181e2c4eb88441a69351fb79607ccc0d99d9a
Author: Andrew Grieve <agrieve@chromium.org>
Date: Mon Jun 11 22:05:37 2018
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/eda04f08eddd1dd26356eec23d08e38731de243e

commit eda04f08eddd1dd26356eec23d08e38731de243e
Author: Nate Fischer <ntfschr@google.com>
Date: Tue Jun 12 00:21:55 2018

Comment 5 by agrieve@chromium.org, Jun 12 2018

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/834b19feaa48459e2f05f86017c4b40aebe81da2

commit 834b19feaa48459e2f05f86017c4b40aebe81da2
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Jun 12 17:38:33 2018
►

Sign in to add a comment