Issue metadata
Sign in to add a comment
|
Flakey WebRTC test blocking Web Platform Test export |
||||||||||||||||||||||
Issue descriptionFiling this as Web Platform Test sheriff. Web Platform Test exporter is blocked on https://chromium-review.googlesource.com/c/chromium/src/+/1074696 due to new flakiness in /webrtc/RTCPeerConnection-setRemoteDescription.html. Out of 10 runs, 8 failed and 2 passed. Detailed run log here: https://travis-ci.org/web-platform-tests/wpt/jobs/385761583 Please help investigate.
,
Jun 1 2018
this should be resolved now that https://github.com/web-platform-tests/wpt/pull/11054 has been merged. See https://github.com/web-platform-tests/wpt/pull/11031 for the discussion.
,
Jun 1 2018
https://github.com/web-platform-tests/wpt/pull/11267 passed after the same error when I reran it after 11054 had landed.
,
Jun 1 2018
Ok tentatively marking this as Fixed.
,
Jun 1 2018
Awesome. Thanks for the quick response! The blocked PR I was looking at was https://github.com/web-platform-tests/wpt/pull/11177. I'll retry the tests there and report back if the issue is not fixed.
,
Jun 1 2018
there still seems to be some flakyness. Manually reloading that page on latest master I can see it alternating between 2 pass/3fail and 1 pass/4 fail. The changing result is the "Negotiation should fire signalingsstate events" test. jan-ivar is looking into it, might be a chrome bug.
,
Jun 1 2018
Ok changing to Started, with a reminder to check back on the issue.
,
Jun 1 2018
,
Jun 1 2018
looks like its an actual flaky thing. Yay for tests exposing this :-)
,
Jun 4 2018
,
Jun 4 2018
The NextAction date has arrived: 2018-06-04
,
Jun 4 2018
What are the implications of a flaky test blocking export? Do failed PRs not get exported at all? Or does it sync them up later? What happens to imports in changes to the same files? Are the two repos out of sync?
,
Jun 4 2018
They show up in https://foolip.github.io/ecosystem-infra-rotation/ and someone on the ecosystem infra team takes a look at how to resolve it. If it is stuck for 3-4 weeks, then for technical reasons it will be reverted from Chromium by import. Once a fix for the flakiness is identified, then the most straightforward thing is to apply it in Chromium, and let both changes be exported. But wherever it is fixed, let me know and I'll make sure the final state is good.
,
Jun 7 2018
foolip: Now https://chromium-review.googlesource.com/c/chromium/src/+/1085302 has landed (blocked-on issue fixed), can we get the export fired up again?
,
Jun 11 2018
,
Jun 11 2018
Does that mean everything has been exported, or does stuff that landed during the time the export was "blocked" require manual intervention?
,
Jun 14 2018
danyao: is the test more stable now or do we need take more action?
,
Jun 14 2018
The tests have been upstreamed to WPT. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hbos@chromium.org
, Jun 1 2018