New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 848740 link

Starred by 1 user
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
█ acondor@chromium.org
cjgrant@chromium.org
█ asimjour@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 733656


Sign in to add a comment

[Standalone] Input down state not cleared when opening 2D popup.

Project Member Reported by mthiesse@chromium.org, Jun 1 2018 
1. Click the security indicator.
2. Click 'details' to open the 2D popup.
3. Press the app button to close the 2D popup.

Now until you click again, scrolling doesn't work - the input is stuck on the down state because the up happened while the popup was showing.


Note that this should be incidentally fixed when Aldo fixes our input to support drags, as the click will only happen on button up. We might want to fix this class of bugs more generally though.

Comment 1 by mthiesse@chromium.org, Jun 4 2018

Owner: acondor@chromium.org
Status: Started (was: Available)
I think Aldo is looking into this issue in general.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b

commit 0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Thu Jun 07 22:15:36 2018

VR: Ensuring consistency of events when transitioning to 2D UI

Also, making sure the source of motion events is set, in order
to avoid warnings from InputEventConsistencyVerifier.

BUG= 848740 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Id1ee62b2d9eb63a6a3058b7a0914914823cf81d9
Reviewed-on: https://chromium-review.googlesource.com/1089856
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565437}
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/AndroidUiGestureTarget.java
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrViewContainer.java
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/content/public/android/java/src/org/chromium/content/browser/MotionEventSynthesizerImpl.java
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/content/public/android/java/src/org/chromium/content/browser/SyntheticGestureTarget.java
[modify] https://crrev.com/0d7abffcc3f8d9f81bd3dea8a2aea9b70bbb390b/content/public/android/java/src/org/chromium/content_public/browser/MotionEventSynthesizer.java

Comment 3 by acondor@chromium.org, Jun 13 2018

Blockedon: 733656
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d51d342022e6950032e02ad06c2aabb82c0a1c49

commit d51d342022e6950032e02ad06c2aabb82c0a1c49
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Fri Jun 15 18:42:36 2018

VR: Adding move support for the platform UI

This enables touch interaction with the web contents, effectively
enabling long press, drag, selection, etc.

Context menu and selection handles are disabled for VR in this CL.

Bug:  842916 ,  733656 ,  848740 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr
Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda
Reviewed-on: https://chromium-review.googlesource.com/1091281
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567745}
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/DEPS
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/android/vr/android_ui_gesture_target.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/ui/android/context_menu_helper.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/content_input_delegate.h
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/elements/platform_ui_element.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/elements/platform_ui_element.h
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/platform_ui_input_delegate.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/platform_ui_input_delegate.h
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/ui.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/ui_suppressed_element.h
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/tools/metrics/histograms/enums.xml
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39e21957a9d9790c1e036b3c103c30e3917dc4ed

commit 39e21957a9d9790c1e036b3c103c30e3917dc4ed
Author: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Date: Mon Jun 18 10:38:34 2018

Revert "VR: Adding move support for the platform UI"

This reverts commit d51d342022e6950032e02ad06c2aabb82c0a1c49.

Reason for revert: A DCHECK is failing on the bots, see bug 853388.

Original change's description:
> VR: Adding move support for the platform UI
> 
> This enables touch interaction with the web contents, effectively
> enabling long press, drag, selection, etc.
> 
> Context menu and selection handles are disabled for VR in this CL.
> 
> Bug:  842916 ,  733656 ,  848740 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr
> Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda
> Reviewed-on: https://chromium-review.googlesource.com/1091281
> Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567745}

TBR=sky@chromium.org,mthiesse@chromium.org,jam@chromium.org,tedchoc@chromium.org,tdresser@chromium.org,acondor@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  842916 ,  733656 ,  848740 , 853388
Change-Id: I24b609f9c2c92efde74b53020a44907e0a30627e
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr
Reviewed-on: https://chromium-review.googlesource.com/1104217
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567965}
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/DEPS
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/android/vr/android_ui_gesture_target.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/ui/android/context_menu_helper.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/content_input_delegate.h
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/elements/platform_ui_element.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/elements/platform_ui_element.h
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/platform_ui_input_delegate.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/platform_ui_input_delegate.h
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/ui.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/ui_suppressed_element.h
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/tools/metrics/histograms/enums.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53195553e54ad8cc0441aa06f33e7c15cf198eef

commit 53195553e54ad8cc0441aa06f33e7c15cf198eef
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Tue Jun 19 21:53:13 2018

Reland "VR: Adding move support for the platform UI"

This is a reland of d51d342022e6950032e02ad06c2aabb82c0a1c49
Previously, we were DCHECKing that touch handles were not being enabled
during VR browsing. This caused some tests to crash, since the VR browser
can not control when those calls are produced. Instead, this CL merges
all the requirements for disabling the touch handles, including the VR mode.

Original change's description:
> VR: Adding move support for the platform UI
>
> This enables touch interaction with the web contents, effectively
> enabling long press, drag, selection, etc.
>
> Context menu and selection handles are disabled for VR in this CL.
>
> Bug:  842916 ,  733656 ,  848740 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr
> Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda
> Reviewed-on: https://chromium-review.googlesource.com/1091281
> Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567745}

Bug:  842916 ,  733656 ,  848740 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I405c57fb91324758834f2d7afe21bb9c2bc937d4
Reviewed-on: https://chromium-review.googlesource.com/1104638
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568609}
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/DEPS
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/android/vr/android_ui_gesture_target.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/ui/android/context_menu_helper.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/content_input_delegate.h
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/elements/platform_ui_element.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/elements/platform_ui_element.h
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/platform_ui_input_delegate.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/platform_ui_input_delegate.h
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/ui.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/ui_suppressed_element.h
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/tools/metrics/histograms/enums.xml

Comment 7 by acondor@chromium.org, Jun 25 2018

Status: Fixed (was: Started)
►

Sign in to add a comment