New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848732 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2

Blocking:
issue 819235



Sign in to add a comment

Use "secure" icon for "secure with policy installed cert" state

Project Member Reported by stkhapugin@chromium.org, Jun 1 2018

Issue description

Please provide assets for the following security state: security_state::SECURE_WITH_POLICY_INSTALLED_CERT. Currently we use 

ios/chrome/app/theme/default_300_percent/controlled_setting_mandatory.png (attached)
 
controlled_setting_mandatory.png
252 bytes View Download
Cc: maxwalker@chromium.org
+Max: do you use the same icon pictured here for this security state on Android? Wondering if we should really have a unique icon or if we should just use the default secure/ssl lock glyph?
Cc: est...@chromium.org
According to
https://codesearch.chromium.org/chromium/src/components/security_state/core/security_state.h?rcl=71cc4cde2be4a15123b8d41786e93161cb86ad87&l=62 SECURE_WITH_POLICY_INSTALLED_CERT is only used on Chrome OS. 

+Emily: could you take a look and confirm?
estark: kindly ping
Owner: stkhapugin@chromium.org
For now lets just use the secure/ssl lock for this state. If we hear that we need to do otherwise, I will draw an icon.
Owner: lod@chromium.org
Summary: Use "secure" icon for "secure with policy installed cert" state (was: Provide an asset for "secure with policy installed cert" state )
Sorry for the delay. Yes, this state is only used on ChromeOS.

Comment 7 by marq@chromium.org, Jun 27 2018

Labels: Q2
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f03c784d02215f407fda19e2a3949c985d3ffd42

commit f03c784d02215f407fda19e2a3949c985d3ffd42
Author: Elodie Banel <lod@google.com>
Date: Wed Jul 04 15:38:09 2018

Remove secure icon todo

The behavior that is expected is the current behavior. Remove todo.

Bug:  848732 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifc0412d8b0cca13e1b1342195608c7daecdbd46c
Reviewed-on: https://chromium-review.googlesource.com/1125733
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572582}
[modify] https://crrev.com/f03c784d02215f407fda19e2a3949c985d3ffd42/ios/chrome/browser/ui/omnibox/omnibox_util.cc

Status: Fixed (was: Assigned)
The behavior was already as stated (using secure icon). Todo removed.

Sign in to add a comment