Use "secure" icon for "secure with policy installed cert" state |
||||||
Issue descriptionPlease provide assets for the following security state: security_state::SECURE_WITH_POLICY_INSTALLED_CERT. Currently we use ios/chrome/app/theme/default_300_percent/controlled_setting_mandatory.png (attached)
,
Jun 5 2018
According to https://codesearch.chromium.org/chromium/src/components/security_state/core/security_state.h?rcl=71cc4cde2be4a15123b8d41786e93161cb86ad87&l=62 SECURE_WITH_POLICY_INSTALLED_CERT is only used on Chrome OS. +Emily: could you take a look and confirm?
,
Jun 7 2018
estark: kindly ping
,
Jun 8 2018
For now lets just use the secure/ssl lock for this state. If we hear that we need to do otherwise, I will draw an icon.
,
Jun 8 2018
,
Jun 8 2018
Sorry for the delay. Yes, this state is only used on ChromeOS.
,
Jun 27 2018
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f03c784d02215f407fda19e2a3949c985d3ffd42 commit f03c784d02215f407fda19e2a3949c985d3ffd42 Author: Elodie Banel <lod@google.com> Date: Wed Jul 04 15:38:09 2018 Remove secure icon todo The behavior that is expected is the current behavior. Remove todo. Bug: 848732 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifc0412d8b0cca13e1b1342195608c7daecdbd46c Reviewed-on: https://chromium-review.googlesource.com/1125733 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#572582} [modify] https://crrev.com/f03c784d02215f407fda19e2a3949c985d3ffd42/ios/chrome/browser/ui/omnibox/omnibox_util.cc
,
Jul 4
The behavior was already as stated (using secure icon). Todo removed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pschaffner@chromium.org
, Jun 4 2018