[SPv175] DCHECK failed in CompositingLayerPropertyUpdater::Update
Reported by
ana...@yandex-team.ru,
Jun 1 2018
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 YaBrowser/18.6.1.209 (beta) Yowser/2.5 Safari/537.36 Example URL: Simple page example below. Occur on some facebook pages, https://www.decathlon.ru/C-98006-samokaty-dlja-vzroslyh Steps to reproduce the problem: 1. Open page with html: <!DOCTYPE html> <html> <head> <style> .cube { position: fixed; height: 100px; width: 100px; background-color: #3366CC; animation:spin 4s linear infinite; } @keyframes spin { 100% { transform:rotate(360deg); } } </style> </head> <body> <div style="height: 3000px;"> <div class="cube" /> </div> </body> </html> 2. Try print page What is the expected behavior? All is well, preview is creating. What went wrong? DCHECK(!fragment_data.NextFragment()) falls in function CompositingLayerPropertyUpdater::Update(). Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Does this work in other browsers? Yes Chrome version: 69.0.3441.0 Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 28.0 r0 This problem occured after the commit https://bugs.chromium.org/p/chromium/issues/detail?id=839424 It occures when we want print pages with fixed elements which have own paint layer and CompositedLayerMapping (which can be creating after some transformation for example). Thanks!!
,
Jun 1 2018
,
Jun 1 2018
We have a couple of CLusterfuzz issues also due to issues with the fragment list.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb0342e88e7e4e142b6c75caf729d4b20e6db4a0 commit bb0342e88e7e4e142b6c75caf729d4b20e6db4a0 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Jun 01 22:35:14 2018 [PE] Fix DCHECK failuer when printing composited position:fixed Bug: 848730 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If75ff284081bc6699abbadba9437d095b97dc418 Reviewed-on: https://chromium-review.googlesource.com/1082931 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#563837} [add] https://crrev.com/bb0342e88e7e4e142b6c75caf729d4b20e6db4a0/third_party/WebKit/LayoutTests/printing/fixed-position-composited-crash-expected.html [add] https://crrev.com/bb0342e88e7e4e142b6c75caf729d4b20e6db4a0/third_party/WebKit/LayoutTests/printing/fixed-position-composited-crash.html [modify] https://crrev.com/bb0342e88e7e4e142b6c75caf729d4b20e6db4a0/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
,
Jun 6 2018
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53a71ab96d5652730ede64622103d51897ff8b34 commit 53a71ab96d5652730ede64622103d51897ff8b34 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Jun 11 20:24:12 2018 Revert "[PE] Fix DCHECK failuer when printing composited position:fixed" This reverts commit bb0342e88e7e4e142b6c75caf729d4b20e6db4a0. Reason for revert: Speculative revert for crbug.com/851383. Original change's description: > [PE] Fix DCHECK failuer when printing composited position:fixed > > Bug: 848730 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: If75ff284081bc6699abbadba9437d095b97dc418 > Reviewed-on: https://chromium-review.googlesource.com/1082931 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563837} TBR=wangxianzhu@chromium.org,trchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848730 , 851383 Change-Id: I24d46ea9ba4c5a7d3aa8c337c68812aec8a043a1 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1095555 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566127} [delete] https://crrev.com/152d2ae1c47a4539ee5367ab3c3075edae2fc17a/third_party/WebKit/LayoutTests/printing/fixed-position-composited-crash-expected.html [delete] https://crrev.com/152d2ae1c47a4539ee5367ab3c3075edae2fc17a/third_party/WebKit/LayoutTests/printing/fixed-position-composited-crash.html [modify] https://crrev.com/53a71ab96d5652730ede64622103d51897ff8b34/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
,
Jun 11 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a22af9fa3e43595d05540d0048a526425359824 commit 1a22af9fa3e43595d05540d0048a526425359824 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Jun 14 00:25:15 2018 [PE] Another method to avoid DCHECK when printing repeating fixed-position objects The previous CL for the bug was reverted because it caused crashes. We may still go through the normal paint path which requires layer states during printing, so for safety don't skip layer state update, but just suppress the DCHECK when printing. Bug: 848730 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9f08af2282c76bb97bd14428eb368791feddbaa8 Reviewed-on: https://chromium-review.googlesource.com/1097558 Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567060} [modify] https://crrev.com/1a22af9fa3e43595d05540d0048a526425359824/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6478b6900b478c9ae4750f181da67a742a43b94 commit b6478b6900b478c9ae4750f181da67a742a43b94 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Jun 14 05:43:55 2018 [PE] Add back test for crbug.com/848730 The test was added in https://chromium-review.googlesource.com/1082931 for the bug, then was reverted. I forgot to add back the test in the new fix https://chromium-review.googlesource.com/1097558. TBR=trchen@chromium.org Bug: 848730 Change-Id: I3823a408819a2d8acdb7e41060d2fafd22fbb6de Reviewed-on: https://chromium-review.googlesource.com/1100486 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567158} [add] https://crrev.com/b6478b6900b478c9ae4750f181da67a742a43b94/third_party/WebKit/LayoutTests/printing/fixed-position-composited-crash-expected.html [add] https://crrev.com/b6478b6900b478c9ae4750f181da67a742a43b94/third_party/WebKit/LayoutTests/printing/fixed-position-composited-crash.html
,
Jun 14 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ana...@yandex-team.ru
, Jun 1 2018324 bytes
324 bytes View Download