New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 848697 link

Starred by 2 users
Status: Fixed
Owner:
y...@chromium.org
Closed: Jul 22
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 816363



Sign in to add a comment

Non-Regression : 'Close' Tool tip is seen missing on hovering mouse pointer on Close Icon in 'Delete' dialog box of Camera App

Project Member Reported by mmanchala@chromium.org, Jun 1 2018 
Chrome Version:​67.0.3396.69/10575.52.0 beta-channel Paine,Kip and Peppy 
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user ->open New camera app (version: 5.0.0) -> Now capture images
(2)Click on camera gallery -> Select any Image -> now click on 'Delete' option
(3)"Do yo really..." Dialog box is seen ,now hover mouse pointer on Close Icon and observe for Tool tip
(Please refer Video)

Actual: 'Close' Tool tip should be seen on hovering mouse pointer on Close Icon in 'Delete' dialog box
Expected: Instead 'Close' Tool tip is seen missing

This is Non-Regression issue

@Yuli: Please confirm the issue
Actual_NoTooltip.webm
17.0 MB Download
Expected_CloseTooltip.jpg
448 KB View Download

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by y...@chromium.org, Jun 29 2018

Labels: -M-67 M-69

Comment 5 by henryhsu@chromium.org, Jul 19

Blocking: 816363
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/24dcf833a82e2d9637174614f39a1b473ca85011

commit 24dcf833a82e2d9637174614f39a1b473ca85011
Author: Yuli Huang <yuli@chromium.org>
Date: Sun Jul 22 02:57:18 2018

Fix dialog-close-button for accessibility.

1. Make dialog-close-button focusable after yes/no buttons.
2. Fix yes/no buttons maybe still focusable after closing dialog.
3. Remove unused string.

BUG= chromium:848697 
TEST=Tested by opening dialog.

Change-Id: I19aa690a47b898d0157b485a1f675d71ad4e7d4e
Reviewed-on: https://chromium-review.googlesource.com/1144599
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/24dcf833a82e2d9637174614f39a1b473ca85011/src/_locales/en/messages.json
[modify] https://crrev.com/24dcf833a82e2d9637174614f39a1b473ca85011/src/views/main.html

Comment 7 by y...@chromium.org, Jul 22

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24dcf833a82e2d9637174614f39a1b473ca85011

commit 24dcf833a82e2d9637174614f39a1b473ca85011
Author: Yuli Huang <yuli@chromium.org>
Date: Sun Jul 22 02:57:18 2018

Fix dialog-close-button for accessibility.

1. Make dialog-close-button focusable after yes/no buttons.
2. Fix yes/no buttons maybe still focusable after closing dialog.
3. Remove unused string.

BUG= chromium:848697 
TEST=Tested by opening dialog.

Change-Id: I19aa690a47b898d0157b485a1f675d71ad4e7d4e
Reviewed-on: https://chromium-review.googlesource.com/1144599
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/24dcf833a82e2d9637174614f39a1b473ca85011/src/_locales/en/messages.json
[modify] https://crrev.com/24dcf833a82e2d9637174614f39a1b473ca85011/src/views/main.html
►

Sign in to add a comment