New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 848681 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Jun 2018
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Enter button is working even when no digits are entered in 'Enter your PIN' overlay of chrome://settings/lockScreen page

Project Member Reported by mmanchala@chromium.org, Jun 1 2018 
Chrome Version:  ​67.0.3396.69/10575.52.0 beta-channel Paine,Kip and Peppy 
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option
2)Now enter User Password in 'Confirm your password' dialog box -> At 'screen lock options' section select 'PIN or Password' option -> click on 'SET UP PIN'
(3)In 'Enter your PIN' overlay don't enter any digits and also Observe 'CONTINUE' button is seen disabled -> Now click on 'Enter' button from keyboard and observe 'Confirm your PIN' overlay is seen
(Please refer Video)


Expected: 'Enter' button should not work until required digits are entered in 'Enter your PIN' overlay
Actual: Instead 'Enter' button is working even when no digits are entered and 'Confirm your PIN' overlay is seen

This is Non-Regression Issue as 'Screen lock' option is introduced from M-57

@sammiequon : Please confirm the Issue
Actual_Pin.webm
928 KB View Download

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by mmanchala@chromium.org, Jun 1 2018

Summary: Non-Regression :Enter button is working even when no digits are entered in 'Enter your PIN' overlay of chrome://settings/lockScreen page (was: Non-Regression :'Enter' button is working even when no digits are entered in 'Enter your PIN' overlay of chrome://settings/lockScreen page)

Comment 5 by mmanchala@chromium.org, Jun 1 2018

Summary: Non-Regression : Enter button is working even when no digits are entered in 'Enter your PIN' overlay of chrome://settings/lockScreen page (was: Non-Regression :Enter button is working even when no digits are entered in 'Enter your PIN' overlay of chrome://settings/lockScreen page)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba8d3dce541ef21a1d01541e7e990b59709b5b04

commit ba8d3dce541ef21a1d01541e7e990b59709b5b04
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Jun 14 20:48:49 2018

settings: Prevent use enter when next button disabled on set up PIN.

Also add a tooltip to PIN keyboard back button.

Test: manual
Bug:  848681 ,  845871 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic1ba4e80ee2386ffe587ffd4bc791a29548e7254
Reviewed-on: https://chromium-review.googlesource.com/1095649
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567394}
[modify] https://crrev.com/ba8d3dce541ef21a1d01541e7e990b59709b5b04/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/ba8d3dce541ef21a1d01541e7e990b59709b5b04/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html

Comment 7 by sammiequon@chromium.org, Jun 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment