New issue
Advanced search Search tips

Issue 848661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Files app has duplicated "Downloads" folder in Android Files.

Project Member Reported by fukino@chromium.org, Jun 1 2018

Issue description

Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Enable flag #show-android-files-in-files-app.
(2) Open Files app and observe the left pane.

What is the expected result?
There is only one "Downloads" directory.

What happens instead?
There are /Downloads and /Android Files/Downloads, and they have the same contents.

I set P3 as the initial priority, since:
- There is no functional problem.
- Users can see this issue only when the user toggles "Show internal storage" option.
- We already have similar situation about duplicated folders. If we mark a Drive folder as favorite, we see the folder as top-level folder in left nav along with the actual folder inside My Drive.
 
Screenshot 2018-06-01 at 5.09.16 PM.png
183 KB View Download
Weifang, can you add a Mstone label for this?
Labels: -Pri-3 M-70 Pri-2
This should be fixed as a follow-on to the M69 launch. I understand that it won't break user functionality, but it will be quite confusing from a UX perspective.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f10ef15488e67517fe90f7d8a9e4cc6cd200b7b0

commit f10ef15488e67517fe90f7d8a9e4cc6cd200b7b0
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Aug 09 09:03:44 2018

Files app: Hide Download folder inside Play files.

"Play files/Download" is an alias to Chrome OS's Downloads volume.
It is convenient in Android file picker, but can be confusing in
Chrome OS Files app.
This CL hides the 'Play files/Download" only in Chrome OS Files app.

Bug:  848661 
Test: Manually tested on arc-enabled Kevin.

Change-Id: I6c9bed8ff7f72b7c1fe6b2abe1c6194f8eeb3b6d
Reviewed-on: https://chromium-review.googlesource.com/1166922
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581834}
[modify] https://crrev.com/f10ef15488e67517fe90f7d8a9e4cc6cd200b7b0/ui/file_manager/file_manager/foreground/js/directory_contents.js

Status: Fixed (was: Started)

Sign in to add a comment