New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

CfM camera reset doesn't work on signed release images

Project Member Reported by lndmrk@chromium.org, Jun 1 2018

Issue description

The CfM camera watchdog performs board specific quirks to reset the camera. It reads the board name (CHROMEOS_RELEASE_BOARD) to determine what board it is. However, signed images adds additional info to that string, which makes the board check function fail.

See b/80220411 for more context.
 
Cc: kbleicher@chromium.org bhthompson@chromium.org
Labels: Merge-Request-67 Merge-Request-68
Status: Started (was: Fixed)
kbleicher@, bhthompson@,

I'd like to backport the following bug fix to R67 and R68. The CL only affects boards built with USE=cfm_enabled_device.

https://chromium-review.googlesource.com/c/chromiumos/platform/cfm-device-monitor/+/1080817
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: katierh@chromium.org
Owner: lndmrk@chromium.org

Comment 5 by sreec@chromium.org, Jun 2 2018

Labels: Merge-Request-67
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 2 2018

Labels: -Merge-Request-67
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This is a bug fix for huddly monitor to function properly on release images. We have some know issues in huddly and rely on huddly monitor to catch the failure and reset the camera. It's a fix for both guado and teemo and it's a launch blocker for teemo-cfm.
Labels: -Merge-Review-67 Merge-Approved-67
I reviewed over IM. Confirmed this has been fully tested and good to go (won't impact prod systems).

Merge approved for M67 chrome OS.  Please ping bhthompson@ for M68.
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 2 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 5 2018

Cc: sreec@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-67 -Merge-Approved-68 Merge-Merged
Status: Fixed (was: Started)

Sign in to add a comment