New issue
Advanced search Search tips

Issue 848639 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Export FirstMeaningfulPaintCandidate() through WebPerformance

Project Member Reported by gyuyoung...@chromium.org, Jun 1 2018

Issue description

FMP(First meaningful paint) signal has sometimes been used for dismissing a splash screen in some downstream Web Application platforms. In other words, they have used the FMP to dismiss a splash screen when FMP signal is detected. But, FMP signal couldn't occasionally be generated or happened a little bit late[1], then it could cause that the splash screen dismissed a little bit late in the Web Application platforms. To solve the case(although it's rare cases), we can export FMPC as well. Then, IMHO, they can dismiss the splash screen more properly.
 
Components: Speed>Metrics
Owner: gyuyoung...@chromium.org
Status: Started (was: Untriaged)
Can you give an example of a "some downstream Web Application platform"?
Yes, I'm working on LGE WebOS(http://webosose.org/). Besides, Tizen(www.tizen.org) also has been using Chromium for their web rendering engine.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c7ee6265864957fdc3f07b49cddd97b89a26897

commit 7c7ee6265864957fdc3f07b49cddd97b89a26897
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Wed Jun 06 10:03:06 2018

Export FirstMeaningfulPaintCandidate() through WebPerformance

FMP signal has sometimes been used for dismissing a splash screen in some
downstream Web Application platforms. But, FMP signal couldn't occasionally
be generated or happened a little bit late, then it could cause that the
splash screen dismissed a little bit late in the Web Application platforms.
This CL is to export FirstMeaningfulPaintCandidate() in order to be used when
FirstMeaningfulPaint() doesn't work or generates a signal a little bit late.

Bug:  848639 
Test: Covered by FirstMeaningfulPaintDetectorTest.FirstMeaningfulPaintCandidate
Change-Id: I492d98ef4998e772d293f81b9991a066cb346233
Reviewed-on: https://chromium-review.googlesource.com/1080499
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#564841}
[modify] https://crrev.com/7c7ee6265864957fdc3f07b49cddd97b89a26897/third_party/blink/public/web/web_performance.h
[modify] https://crrev.com/7c7ee6265864957fdc3f07b49cddd97b89a26897/third_party/blink/renderer/core/exported/web_performance.cc
[modify] https://crrev.com/7c7ee6265864957fdc3f07b49cddd97b89a26897/third_party/blink/renderer/core/timing/performance_timing.cc
[modify] https://crrev.com/7c7ee6265864957fdc3f07b49cddd97b89a26897/third_party/blink/renderer/core/timing/performance_timing.h

Status: Fixed (was: Started)
The CL was landed yesterday. So I'd like to close this bug as fixed. I'll re-open this bug if there is any issue.

Sign in to add a comment