Bookmark bar items have excessive padding/spacing (significantly fewer items fit than before)
Reported by
ayanam...@gmail.com,
Jun 1 2018
|
|||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36 Steps to reproduce the problem: 1. add some bookmark directory to bookmark bar 2. 3. What is the expected behavior? What went wrong? bookmark bar space between icon and text are too wide Did this work before? N/A Chrome version: 67.0.3396.62 Channel: stable OS Version: 10.0 Flash Version: There are other people report the same issue https://www.zhihu.com/question/279345471
,
Jun 1 2018
I keep "UI Layout for the browser's top chrome" and "Material Design in the rest of the browser's native UI" as "Default" but not "Enabled". It seems these flags is enabled by Chrome 67, although i can disable them, i think fix the issue is the best way.
,
Jun 1 2018
,
Jun 5 2018
This issue looks similar to issue 700672 , Hence cc'ing kylixrd@ from that bug on further inputs. Thanks!
,
Jun 8 2018
Gentle ping...!! kylixrd@ - Could you please have a look into the issue. Thanks...!!
,
Jun 8 2018
This may be working as intended. Adding pbos@ since he's worked on this area recently and may be able to confirm.
,
Jun 9 2018
I am experiencing this on Linux too. It happened just after upgrading to: Version 68.0.3440.17 (Official Build) beta (64-bit)
,
Jun 9 2018
Additionally, the comments in #1 made no difference. My was set as Default, changing to Disabled made no difference.
,
Jun 11 2018
pbos@ Gentle Ping... As per comment #6, request you to please look into the issue and help in further triaging. Thanks..
,
Jun 12 2018
As per comment#10 closing this issue as wont-fix. Please feel free to re-open if this is not the case. Thanks!
,
Jun 13 2018
Issue 852187 has been merged into this issue.
,
Jun 23 2018
This is a poor design decision for people who don't use touch-screen devices. We have been hearing loud and clear the dislike for this change. https://productforums.google.com/forum/#!msg/chromebook-central/SOtol7Lxgs4/LixPXkIMCgAJ At least keep the #top-chrome-md flag. Better yet, make bookmark icon spacing a Settings feature.
,
Jun 25 2018
This bug is specifically referring to the text spacing between the favicon and text in side a bookmark button in the Refresh or Normal modes. That email thread refers to the difference between Touchable and other modes. That problem is specifically that a hybrid device that has a touchscreen (say Pixelbook) is considered touchable even if the user isn't using the touchscreen for input, so we use the touchable layout even when the user is not using the touchscreen. +markchang FYI
,
Jul 24
Chrome 68.0.3440.75 a similar problem https://productforums.google.com/forum/#!topic/chrome-ru/6JztpB5pqAE;context-place=forum/chrome-ru chrome://flags/#enable-md-bookmarks - flag is canceled chrome://flags/#secondary-ui-md the flag does not solve the problem in any way chrome://flags/#top-chrome-md the flag does not solve the problem in any way
,
Jul 25
+1 Please fix the spacing between the icons / entries in the bookmarks bar I also have to agree with: chrome://flags/#secondary-ui-md the flag does not solve the problem in any way chrome://flags/#top-chrome-md the flag does not solve the problem in any way
,
Jul 25
New topics from users: https://productforums.google.com/forum/#!topic/chrome/le-Kt1JcerM;context-place=topicsearchin/chrome/bookmarks%7Csort:date https://productforums.google.com/forum/#!topic/chrome/6kWYqkrq_0Y;context-place=topicsearchin/chrome/bookmarks%7Csort:date https://productforums.google.com/forum/#!topic/chrome/gvAtV20M05A;context-place=topicsearchin/chrome/bookmarks%7Csort:date https://productforums.google.com/forum/#!topic/chrome/bjazFjboshw;context-place=topicsearchin/chrome/bookmarks%7Csort:date https://productforums.google.com/forum/#!topic/chrome/hfxMtDxpLJc;context-place=topicsearchin/chrome/bookmarks%7Csort:date https://productforums.google.com/forum/#!topic/chrome/rP9y8xIt7Qo;context-place=topicsearchin/chrome/bookmarks%7Csort:date https://productforums.google.com/forum/#!topic/chrome/KJEmwjibK1A;context-place=topicsearchin/chrome/bookmarks%7Csort:date in the RU region: https://productforums.google.com/forum/#!topic/chrome-ru/pCPU1RhKJ3w https://productforums.google.com/forum/#!topic/chrome-ru/ON7xkSiIjj8
,
Jul 25
This change does not make sense for non-touch enabled devices. I'm running Chrome desktop 68.0.3440.75 on windows 8.1, there's no touch functionality on this PC. Please give us an option/flag or something to get back to the proper spacing. I attached a before/after comparison so you can see what this looks like in the real world. The last 5 or so items in my bookmarks bar now go behind a menu. None of the flags mentioned above helped.
,
Jul 26
Aaaaaaa !!! Bring back the small indentation! Make it a setting! I have no more icons in the panel.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c96fb3ee8abd6689133ba664af9f42ad7bb0a4b9 commit c96fb3ee8abd6689133ba664af9f42ad7bb0a4b9 Author: Peter Boström <pbos@chromium.org> Date: Thu Jul 26 20:39:04 2018 Decrease padding between bookmark-bar items Gives 4dp of whitespace back to the user (in Refresh) by using TOOLBAR_ELEMENT_PADDING. This unifies the bookmark item spacing with toolbar items. Bug: chromium:848631 Change-Id: I20c2ea5735f93a4db2d7c7e6c218ed4bd528c458 Reviewed-on: https://chromium-review.googlesource.com/1152029 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#578426} [modify] https://crrev.com/c96fb3ee8abd6689133ba664af9f42ad7bb0a4b9/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
,
Jul 26
TPM: Requesting merge to M69, this is low-risk and we're changing a spacing constant from an 8 to a 4. We've reduced spacing between items from 8dp to 4dp outside ChromeOS touchable devices. Hopefully this gives some fair amount of whitespace back even if it is not fully on par with prior versions.
,
Jul 27
Unable to reproduce the issue on build without fix, hence unable to verify the fix on latest canary 69.0.3504.0. Attaching screenshots of build with and without fix. @pbos: Please help in verifying the fix on latest canary. Thanks!
,
Jul 27
@ comment 23: I can confirm this is fixed! I downloaded latest canary from https://download-chromium.appspot.com/ (Build Revision: 578616), imported my bookmarks and it looks great again! Please release the fix to the current stable channel (v68)! Thanks!
,
Jul 27
TE: You can see that the bookmark items are slightly denser, meaning that you can fit more bookmarks into the bar (when you have significantly more than 3). Thanks for verifying. This sort of regression generally doesn't warrant merging to stable (this is generally reserved for security fixes and crashes). I've requested one for M69 (which hopefully gets approved), so you should have it on your stable in the next release. If you can't wait for that and you're fine with a less-stable (but generally stable) Chrome, there are other releases that would get these changes faster (beta, dev): https://www.chromium.org/getting-involved/dev-channel
,
Jul 27
,
Jul 27
why should I and the rest of the users have to wait 1.5 months because of your mistake? or betting or dev that can corrupt the user profile and will not transfer extensions on the transition! release now update, this is a serious mistake in chrome! you've seen how many new topics on the forum people have created and how many times have they accessed through the help in the browser.
,
Jul 27
I think this is at least worth asking to merge to M68. This is the second-most-common M68 complaint I've seen after color profile stuff, it sounds like we're planning a 68 respin anyway, and the fix seems safe.
,
Jul 27
SG, if we're doing a respin anyways it would be good to have this in there.
,
Jul 27
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
"This is the second-most-common M68 complaint I've seen after color profile stuff" yes, but the color profile can be fixed with flags, but it is not.
,
Jul 27
Thanks pbos@ for the fix - seems like it landed in Canary and is fixed. I assume this is a very safe fix and good to merge cleanly in M68?
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ba94382ad291d1c817788eab9a0f5a5335584ce commit 9ba94382ad291d1c817788eab9a0f5a5335584ce Author: Peter Boström <pbos@chromium.org> Date: Fri Jul 27 21:37:31 2018 Decrease padding between bookmark-bar items Gives 4dp of whitespace back to the user (in Refresh) by using TOOLBAR_ELEMENT_PADDING. This unifies the bookmark item spacing with toolbar items. (cherry picked from commit c96fb3ee8abd6689133ba664af9f42ad7bb0a4b9) Bug: chromium:848631 Change-Id: I20c2ea5735f93a4db2d7c7e6c218ed4bd528c458 Reviewed-on: https://chromium-review.googlesource.com/1152029 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578426} Reviewed-on: https://chromium-review.googlesource.com/1153727 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#177} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/9ba94382ad291d1c817788eab9a0f5a5335584ce/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
,
Jul 27
I wanna say yes. crrev.com/c/1153727 had a (trivial) merge conflict, hoping to use that as a base for the M68 merge.
,
Jul 28
,
Jul 28
+1 People seem to be complaining a lot in this thread too -- https://productforums.google.com/forum/#!msg/chrome/6kWYqkrq_0Y/F01-4NgsCwAJ This is the second thing that annoyed me after Chrome turning into Yellow, when upgraded to 68...
,
Jul 28
The situation in Canary is still problematic. The padding between the icons and labels in the bookmark buttons remains excessive, to the point where it hampers the user's ability to visually associate the two at a glance. For reference, see Google's own Material Design guidelines on buttons: https://material.io/design/components/buttons.html#specs The guidelines state that the padding between a button's icon and its label should be 8dp, compared to 12dp on the left of the icon to the button's left edge, and 16dp on the right of the label to the button's right edge. As it stands, Canary violates these best practices. The padding between the bookmark icon and the label is greater than the padding on either the left or right of the button. The change to reduce inter-item padding has returned some real estate to the user, but has also exacerbated the issue of icon/label visual association, as now the inter-item spacing is almost the same as the icon/label padding, making it even harder for the user to visually group the two at a glance. Please do not just have a programmer tweak some padding variable again. Refer this issue to a UX designer internally at Google and have them determine a set of padding and spacing sizes that will meet usability requirements.
,
Jul 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0de5395627397e1a89bc4a22f4c770f17df877bc commit 0de5395627397e1a89bc4a22f4c770f17df877bc Author: Peter Boström <pbos@chromium.org> Date: Sun Jul 29 06:06:26 2018 Decrease padding between bookmark-bar items Gives 4dp of whitespace back to the user (in Refresh) by using TOOLBAR_ELEMENT_PADDING. This unifies the bookmark item spacing with toolbar items. (cherry picked from commit c96fb3ee8abd6689133ba664af9f42ad7bb0a4b9) (cherry picked from commit 9ba94382ad291d1c817788eab9a0f5a5335584ce) Bug: chromium:848631 Change-Id: I20c2ea5735f93a4db2d7c7e6c218ed4bd528c458 Reviewed-on: https://chromium-review.googlesource.com/1152029 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#578426} Reviewed-on: https://chromium-review.googlesource.com/1153727 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3497@{#177} Cr-Original-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} Reviewed-on: https://chromium-review.googlesource.com/1154436 Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#768} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/0de5395627397e1a89bc4a22f4c770f17df877bc/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
,
Jul 29
Splitting out the issue in #38 to issue 868697 (and renaming this bug title) as this thread has mostly become about fitting fewer items into the bookmark bar. The fix in #21 is now merged to all branches (next stable, beta, dev) and should roll out as these branches build and release (unless the fix gets reverted). Restricting comments here to prevent this from becoming a pile-on issue for any other bookmark item feedback. Feel free to open new bugs for issues that you see, I just don't want this item to try to cover everything.
,
Jul 29
Issue 868681 has been merged into this issue.
,
Jul 31
Able to reproduce the issue on build without fix, hence verifying the issue on #68.0.3440.84 using Windows 10. Now Bookmark bar fits more number of bookmarks. Attaching screenshots for reference. As fix is working as expected adding TE-Verified labels. Thanks!
,
Aug 1
Able to reproduce the issue on build without fix, hence verifying the issue on latest dev #69.0.3497.23 using Windows 10. Now Bookmark bar fits more number of bookmarks. Attaching screenshots for reference. As fix is working as expected adding TE-Verified labels. Thanks! |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by woxxom@gmail.com
, Jun 1 2018