Issue metadata
Sign in to add a comment
|
Scaled emoji glyph is not painted at certain scale |
||||||||||||||||||||||
Issue descriptionVersion: 69.0.3446.0 Using the same test case in bug 739643: https://t.d3fc.io/status/705212795936247808 Open it on Mac (tested on 10.13.4 Retina) Expected: The sailboat should be visible from the start. Actual: The sailboat is only visible after several seconds when the scale is smaller than a certain value. Bisected to https://chromium.googlesource.com/chromium/src/+/a4cdcba00e74864933bb96acb56d3140733633d2 which is a skia roll. bsalomon@ could you triage the bug?
,
Jun 1 2018
Thanks for filing it, saw the boat missing esp. at the beginning and hoped it'd look odd to you too :-)
,
Jun 1 2018
This seems likely to be related to this change from the roll: 2018-05-23 jvanverth Add GPU perspective support for color emoji
,
Jun 1 2018
Duplicated on Windows by zooming to 200% to match Retina resolution.
,
Jun 1 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/70276915db0c4ec604213c61cb69d8f0419e0e60 commit 70276915db0c4ec604213c61cb69d8f0419e0e60 Author: Jim Van Verth <jvanverth@google.com> Date: Fri Jun 01 18:31:47 2018 Set bounds correctly for color emoji that need post-cache transfoms We need to handle the bounds for transformed color emoji the same way we handle the bounds for distance field text. Without this bounds correction, the glyphs were being clipped out. Also adds a sample to test this case. Bug: 848616 Change-Id: I39dedbe2fd19331ad67978c95519f5c9d46f59fc Reviewed-on: https://skia-review.googlesource.com/131523 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Jim Van Verth <jvanverth@google.com> [modify] https://crrev.com/70276915db0c4ec604213c61cb69d8f0419e0e60/src/gpu/ops/GrAtlasTextOp.cpp [modify] https://crrev.com/70276915db0c4ec604213c61cb69d8f0419e0e60/src/gpu/text/GrTextBlob.cpp [add] https://crrev.com/70276915db0c4ec604213c61cb69d8f0419e0e60/samplecode/SampleGlyphTransform.cpp [modify] https://crrev.com/70276915db0c4ec604213c61cb69d8f0419e0e60/gn/samples.gni [modify] https://crrev.com/70276915db0c4ec604213c61cb69d8f0419e0e60/gm/3dgm.cpp [modify] https://crrev.com/70276915db0c4ec604213c61cb69d8f0419e0e60/src/gpu/text/GrTextBlob.h
,
Jun 1 2018
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6da759f736ca285e685b5276cf6c988c111e90c2 commit 6da759f736ca285e685b5276cf6c988c111e90c2 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 01 22:39:46 2018 Roll src/third_party/skia 8683037..0ba9fa0 (6 commits) https://skia.googlesource.com/skia.git/+log/8683037..0ba9fa0 git log 8683037..0ba9fa0 --date=short --no-merges --format='%ad %ae %s' 2018-06-01 bsalomon@google.com Remove GrGpu::getWritePixelsInfo 2018-06-01 brianosman@google.com Decorate project names with their relative path in the meta SLN 2018-06-01 brianosman@google.com Revert "Rename sg tests and samples targets to fix Visual Studio name conflict" 2018-06-01 bsalomon@google.com Replace GrContextPriv::read/writeSurfacePixels with GrContextPriv::read/WritePixels2 2018-06-01 benjaminwagner@google.com Remove GalaxyS7 ATT jobs. 2018-06-01 jvanverth@google.com Set bounds correctly for color emoji that need post-cache transfoms Created with: gclient setdep -r src/third_party/skia@0ba9fa0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:848616 TBR=rmistry@chromium.org Change-Id: Ica8de7bbba23b5ab07d0e049d6802d2e5dce05f9 Reviewed-on: https://chromium-review.googlesource.com/1082969 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#563838} [modify] https://crrev.com/6da759f736ca285e685b5276cf6c988c111e90c2/DEPS
,
Jun 4 2018
Appears to be working in 69.0.3449.0, please verify.
,
Jun 5 2018
Able to reproduce this issue on reported version 69.0.3446.0, hence verifying the fix on latest canary 69.0.3450.0 using Mac 10.13.3 Retina. Now on navigating to https://t.d3fc.io/status/705212795936247808, sailboat is seen immediately. As fix is working as expected adding Verified labels. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by wangxianzhu@chromium.org
, Jun 1 2018