New CryptAuth enrollments lack "supported features" field |
|||||
Issue descriptionWhen devices enroll with CryptAuth, they send up a GcmDeviceInfo proto, which should contain a list of supported features. Currently, the GcmDeviceInfo proto does *not* contain that field. This list will be used in the M-69 timeframe for the unified multi-device setup flow. Thus, because enrollment only occurs once every 30 days, this updated GcmDeviceInfo proto should be sent to the back-end via the enrollment flow in the M-68 timeframe to ensure that the supported features have had time to propagate to CryptAuth.
,
Jun 1 2018
,
Jun 2 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7f94c6bee36b14c1a07312719065e19da68c581 commit a7f94c6bee36b14c1a07312719065e19da68c581 Author: Kyle Horimoto <khorimoto@google.com> Date: Sat Jun 02 19:03:40 2018 [CrOS MultiDevice] Set appropriate supported features on GcmDeviceInfo. (1) The GcmDeviceInfo proto should refer to intrinsic properties of a device. Whether a feature is enabled is a mutable property of a device which can be changed, so it does not belong in this proto. (2) GcmDeviceInfoProviderImpl now sets supported features. TBR=khorimoto@google.com (cherry picked from commit b4f9c376f6c56d01d26e89e7b10b5fba0a8d78dc) Bug: 848611 , 824568, 752273 Change-Id: I4e26b6f26f4b61b48b9b6c841e80fa3be0b24742 Reviewed-on: https://chromium-review.googlesource.com/1082011 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563526} Reviewed-on: https://chromium-review.googlesource.com/1083964 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#120} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/a7f94c6bee36b14c1a07312719065e19da68c581/chrome/browser/chromeos/cryptauth/gcm_device_info_provider_impl.cc [modify] https://crrev.com/a7f94c6bee36b14c1a07312719065e19da68c581/components/cryptauth/proto/cryptauth_api.proto
,
Jun 2 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2018