New issue
Advanced search Search tips

Issue 848607 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 922212



Sign in to add a comment

Implement Import Maps

Project Member Reported by kouhei@chromium.org, Jun 1 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a26f19641498034dd01c309a878990eaeeced9a

commit 8a26f19641498034dd01c309a878990eaeeced9a
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Jun 07 05:05:35 2018

Make Modulator::ResolveModuleSpecifier virtual.

After package-name-maps, the module specifier resolution algorithm
will need to reference the settings object to access package name map.
This CL makes the Modulator::ResolveModuleSpecifier(), which maps to
https://html.spec.whatwg.org/multipage/webappapis.html#resolve-a-module-specifier
take a settings object |this| by making it virtual.

Bug: 848607
Change-Id: I9592fff1d291e0fea3ec4c471ae76b38d4a43aa9
Reviewed-on: https://chromium-review.googlesource.com/1081780
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565186}
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc
[add] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/document_modulator_impl_test.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/modulator.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/modulator.h
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/modulator_impl_base.h
[delete] https://crrev.com/434ec1f430b591dcbb251e1c54b28b3c583ba8bb/third_party/blink/renderer/core/script/modulator_test.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/module_script.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/script/script_module_resolver_impl_test.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/testing/dummy_modulator.cc
[modify] https://crrev.com/8a26f19641498034dd01c309a878990eaeeced9a/third_party/blink/renderer/core/testing/dummy_modulator.h

Cc: kouhei@chromium.org
Owner: hirosh...@chromium.org
Labels: -Pri-3 Pri-1
Summary: Implement Import Maps (was: Implement package-name-maps)
Blockedon: 922212

Sign in to add a comment