ServiceWorkerNewScriptLoader should not wait for OnStartLoadingResponseBody() when OnComplete() is called |
||||||
Issue descriptionMojoAsyncResourceHandler doesn't call OnStartLoadingResponseBody() when the body length is zero byte. SWNewScriptLoader assume that it's called before OnComplete, so it waits for a body data pipe forever.
,
Jun 1 2018
,
Jun 1 2018
Thanks for the pointer!
,
Jun 4 2018
(So just to clarify this won't block Proj-Servicification-Canary until issue 826868 is fixed while the other issue is marked to block Canary so this will block it too)
,
Jun 6 2018
,
Jun 8 2018
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/407e4de01e534567b5c9b7e453cbdf7b79f467af commit 407e4de01e534567b5c9b7e453cbdf7b79f467af Author: Makoto Shimazu <shimazu@chromium.org> Date: Mon Jun 11 10:22:29 2018 NetS13nServiceWorker: don't assume OnStartLoadingResponseBody() is called In the current implementation, ServiceWorkerNewScriptLoader assume that OnScriptLoadingResponseBody() is called before OnComplete(). However, MojoAsyncResourceHandler doesn't call it when response body is empty. This CL is to adopt that based on discussion at crbug.com/826868 . Bug: 848606 , 826868 Change-Id: I46646fc2d48c51aa89e02d63c057ef42e74ebb7d Reviewed-on: https://chromium-review.googlesource.com/1088463 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565953} [modify] https://crrev.com/407e4de01e534567b5c9b7e453cbdf7b79f467af/content/browser/service_worker/service_worker_new_script_loader.cc [modify] https://crrev.com/407e4de01e534567b5c9b7e453cbdf7b79f467af/content/browser/service_worker/service_worker_new_script_loader.h [modify] https://crrev.com/407e4de01e534567b5c9b7e453cbdf7b79f467af/content/browser/service_worker/service_worker_new_script_loader_unittest.cc [modify] https://crrev.com/407e4de01e534567b5c9b7e453cbdf7b79f467af/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 12 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mek@chromium.org
, Jun 1 2018