New issue
Advanced search Search tips

Issue 848604 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Lifecycle: external/wpt/lifecycle/freeze.html crashes with Network Service

Project Member Reported by kinuko@chromium.org, Jun 1 2018

Issue description

Example logs:
https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20Linux/14027
https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20Linux/14028

Log:
crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: CONSOLE ERROR: line 23: Only fetch keepalive is allowed during onfreeze: http://web-platform.test:8001/lifecycle/resources/foo.txt
STDERR: CONSOLE ERROR: line 42: Only fetch keepalive is allowed during onfreeze: http://web-platform.test:8001/lifecycle/resources/foo.txt
STDERR: CONSOLE WARNING: line 40: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
STDERR: CONSOLE ERROR: line 42: Only fetch keepalive is allowed during onfreeze: http://web-platform.test:8001/lifecycle/resources/foo.txt
STDERR: [1:1:0531/133558.285693:FATAL:frame_scheduler_impl.cc(599)] Check failed: !parent_page_scheduler_->IsPageVisible(). 
STDERR: #0 0x00000380a3fc base::debug::StackTrace::StackTrace()
STDERR: #1 0x000003785a9b logging::LogMessage::~LogMessage()
STDERR: #2 0x000002cf2a30 blink::scheduler::FrameSchedulerImpl::CalculateThrottlingState()
STDERR: #3 0x000002ce7290 blink::FrameOrWorkerScheduler::NotifyThrottlingObservers()
STDERR: #4 0x000002d0d519 blink::scheduler::PageSchedulerImpl::SetPageFrozenImpl()
STDERR: #5 0x000006b4ca1f gin::internal::Dispatcher<>::DispatchToCallback()
STDERR: #6 0x0000022a6753 v8::internal::FunctionCallbackArguments::Call()
STDERR: #7 0x0000022a4ab2 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
STDERR: #8 0x0000022a2e78 v8::internal::Builtin_Impl_HandleApiCall()
STDERR: #9 0x0000022a28bd v8::internal::Builtin_HandleApiCall()
STDERR: #10 0x1f4aac6b3c24 <unknown>
STDERR: 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96f4a75a42946074d71a7c84965e0bb505e4c446

commit 96f4a75a42946074d71a7c84965e0bb505e4c446
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Fri Jun 01 03:35:12 2018

PageLifeCycle: lifecycle/freeze.html crashes with Network Service

STDERR: [1:1:0531/133558.285693:FATAL:frame_scheduler_impl.cc(599)] Check failed: !parent_page_scheduler_->IsPageVisible().

TBR=fmeawad@chromium.org

Bug: 837709,  848604 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6635515300bd5f9f2250584f2250d76c2510828d
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1081778
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563523}
[modify] https://crrev.com/96f4a75a42946074d71a7c84965e0bb505e4c446/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14bf1ca3049897e85e1dd527ef0ec51f65ea5e7c

commit 14bf1ca3049897e85e1dd527ef0ec51f65ea5e7c
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Wed Jun 06 20:54:11 2018

[PageLifecycle] Fix WPT test by hiding the page before freezing

Freezing can only work on hidden pages, currently there is no easy way
in webdriver that allows us to hide the page.

A new webdriver API is in the works to enable that, but meanwhile, for
all testing API, we have to couple hiding with freezing.

This CL does that and reenables the test with Network Service.

Bug: 837709,  848604 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib5c513aefb219cef38a563be81fe8abf4b354051
Reviewed-on: https://chromium-review.googlesource.com/1089354
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565031}
[modify] https://crrev.com/14bf1ca3049897e85e1dd527ef0ec51f65ea5e7c/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/14bf1ca3049897e85e1dd527ef0ec51f65ea5e7c/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/14bf1ca3049897e85e1dd527ef0ec51f65ea5e7c/third_party/WebKit/LayoutTests/external/wpt/lifecycle/freeze.html
[modify] https://crrev.com/14bf1ca3049897e85e1dd527ef0ec51f65ea5e7c/third_party/WebKit/LayoutTests/external/wpt/lifecycle/resources/window.html

Status: Fixed (was: Untriaged)

Sign in to add a comment