Set max text size of bookmark text field a little larger |
||||||||||||
Issue descriptionTo compensate for less space in bookmarks bar due to padding, increase the truncation threshold. bettes@ for guidance first.
,
Jun 28 2018
,
Jul 12
,
Jul 24
Assigning to bettes@ for the min size.
,
Jul 26
,
Aug 2
My suggestion here is to add just enough space for 1 additional character, which falls around 12dp and matches current stable. Unrelatedly, we're inconsistent in how we do truncation. Filed at crbug.com/870158
,
Aug 9
Routing to pbos@
,
Aug 9
Is this bug just adding 12dp to kBookmarkBarMaxButtonWidth? https://cs.chromium.org/chromium/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc?l=126&rcl=ce49639fbef25e273bcc072154c7abed2894d052 cyan@: Tag you're it.
,
Aug 9
I assume this is not a M69 merge candidate? Upping milestone, move back and P1 if otherwise.
,
Aug 9
Btw, this sounds equally arbitrary both before and after and will reduce the total number of bookmarks in the bar (which users will be loud about). Do we really need this change? This request looks like it's based on "up.googleplex.com" which is of arbitrary length. Taking it back until we agree anything needs to be done here.
,
Aug 9
To be clear, I propose that we WontFix this. Consider issue 868697 to get some (but not all) previous space back.
,
Aug 13
-> markchang@ for retriage.
,
Aug 15
re: c11, fair enough. WontFix sgtm as well
,
Aug 15
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by markchang@chromium.org
, Jun 7 2018