New issue
Advanced search Search tips

Issue 848590 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Set max text size of bookmark text field a little larger

Project Member Reported by markchang@chromium.org, Jun 1 2018

Issue description

To compensate for less space in bookmarks bar due to padding, increase the truncation threshold.

bettes@ for guidance first.
 
Owner: ----
Labels: Hotlist-Polish
Labels: Group-Toolbar
Labels: -Pri-3 Pri-2
Owner: bettes@chromium.org
Status: Assigned (was: Available)
Assigning to bettes@ for the min size.
Labels: M-69 Target-69
Owner: robliao@chromium.org
Status: Available (was: Assigned)
My suggestion here is to add just enough space for 1 additional character, which falls around 12dp and matches current stable. 

Unrelatedly, we're inconsistent in how we do truncation. Filed at  crbug.com/870158 
bkmrk.png
229 KB View Download
Owner: pbos@chromium.org
Routing to pbos@
Cc: pbos@chromium.org
Owner: cyan@chromium.org
Status: Assigned (was: Available)
Is this bug just adding 12dp to kBookmarkBarMaxButtonWidth?

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc?l=126&rcl=ce49639fbef25e273bcc072154c7abed2894d052

cyan@: Tag you're it.
Labels: -M-69 -Target-69 Target-70 M-70
I assume this is not a M69 merge candidate? Upping milestone, move back and P1 if otherwise.
Cc: cyan@chromium.org
Owner: pbos@chromium.org
Btw, this sounds equally arbitrary both before and after and will reduce the total number of bookmarks in the bar (which users will be loud about). Do we really need this change? This request looks like it's based on "up.googleplex.com" which is of arbitrary length.

Taking it back until we agree anything needs to be done here.
To be clear, I propose that we WontFix this. Consider  issue 868697  to get some (but not all) previous space back.
Owner: markchang@chromium.org
-> markchang@ for retriage.
re: c11, fair enough. 
WontFix sgtm as well
Status: WontFix (was: Assigned)

Sign in to add a comment