New issue
Advanced search Search tips

Issue 848588 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Data Saver doesn't show savings in Chrome OS

Reported by barkerin...@gmail.com, Jun 1 2018

Issue description

ARC runtime version:
App version: Data Saver Version 2.0.2

Chrome: 65.0.3325.209
Platform: Acer Chromebook 15, model CB5-571

Repro steps:
1) Data Saver consistently shows 0% data saved.
2) Data Saver worked fine for a year until (I think) latest Chrome update.
3) Tried to check proxy server settings per troubleshooting procedure but cannot locate proxy server settings under "Settings".


 

Comment 1 by b...@chromium.org, Jun 1 2018

Components: Internals>Network>DataProxy
Labels: Needs-Feedback OS-Chrome
hi, thanks for reporting this. Can you please file a feedback report from within Chrome? Sending the feedback report from Chrome attaches metrics to the report which makes it possible for us to debug the issue. Instructions for sending the feedback report:
https://support.google.com/chrome/answer/95315?co=GENIE.Platform%3DDesktop&hl=en
Can anyone help me with this?

Am I the only one who is reporting this problem?
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 7 2018

Cc: tbansal@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I did a Powerwash and the Data Saver extension resumed working.

But next day Data Saver quit again.

Did another Powerwash and Data Saver okay again.

Looks like this might become a daily practice.
Labels: Needs-Feedback
Hi OP, Can you explain how you determine if the data saver is working or not? 

Note that the data saver currently proxies only the http webpages (and not https). So, the observed savings may vary from day-to-day based on the type of websites browsed by the user. If the user browses mostly http websites, then the savings would be higher.
Clicking on the Data Saver icon shows Data Usage = 0 bytes. 

Clicking on Details also shows 0 bytes used.

Thanks.
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 11 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hi OP,

Have you enabled the data saver using the data saver extension? You can verify that by looking at the checkbox in the extension interface.

There is a known bug on desktop where if the data saver is not enabled, then the extension does not show data usage count properly. However, if the data saver is enabled (the checkbox is enabled), then the data usage should not have been 0.
Thanks, yes, data saver is enabled.
Labels: M-69
Owner: rajendrant@chromium.org
Status: Assigned (was: Unconfirmed)
If data saver is enabled, then this seems like a different bug. Assigning to rajendrant@ to take a look at this.
Status: Started (was: Assigned)
Summary: Data Saver doesn't show savings in Chrome OS (was: Data Saver doesn't)
I am able to reproduce this issue in chromeos.
I will rootcause and fix this.

I suspect CDUA is getting disabled via this code:
https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc?rcl=752dbfde3778415a318dec924989a3a9c5170eb6&l=432
Cc: bengr@chromium.org
I am delaying working on this bug, since CDUA migration work in happening.

Comment 14 by bengr@chromium.org, Jun 19 2018

Cc: -tbansal@chromium.org rajendrant@chromium.org
Owner: tbansal@chromium.org
Tarun, Raj suspects your code. Can you confirm?
I am not sure why this has RVG label given that the bug was filed by an outsider?

I am going to remove RVG since there does not seem anything google-sensitive here.
Labels: -Restrict-View-Google
Re #12: rajendrant: Can you list the repro steps here. Thanks.
Cc: tbansal@chromium.org
Owner: rajendrant@chromium.org
Assigning back to Raj to get the details on the repro. Raj, can you also summarize your findings from the feedback report filed by the OP? Thanks!
Repro is to reboot with DRP enabled.
When chromeos boots to login screen, DRP is not enabled (profile is not loaded?)
So CDUA gets disabled.
Once the user logs in DRP is enabled. But CDUA is left disabled.

As discussed with Tarun, we did not want to enable CDUA at this point (from a previously disabled state) since it could expect UserData in requests and behave in a weird manner.

I also saw that DataReductionProxy.StartupState is logged two times. Once with state disabled (at login screen), and once as enabled (when user logs in).

https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc?rcl=f9b9a0c8e47d63178ad3262ca3dc79efef1f3080&l=291

We also discussed if this issue should be fixed now, since CDUA migration is happening.
We disable CDUA on ChromeOS when data saver is disabled. This check happens at the time of browser startup. If later, the user enables data saver in the session, then CDUA does not report anything. Chrome has to be restarted before CDUA starts working again.
This was a bandaid solution for all the crashes happening due to CDUA on desktop.

ChromeOS makes this situation complicated as the decision to enable CDUA is decided at the time of machine startup. However, DRP is enabled after the user logs in. May be we can check for the DRP state in the main profile on Chrome OS.
Any progress on this issue?

thanks,

Don
I'm curious what the status of this issue is. Has a solution ben found?

thanks,

Don
Hi Don,

Yes. We have committed the fix.
I have verified the issue is fixed in Chrome OS.
We will be rolling out the fix in M69, in a few weeks.

Thanks
Thanks!
I have M69 now but data saver still doesn't work. Any suggestions?

thanks,

Don
Status: Fixed (was: Started)
Fixed and fully launched now.
Thank you Rajendrant! It's working for me again!

I am seeing 13.6% savings this morning.

thanks again,

Don

Sign in to add a comment