+fukino who will be relevant to ARC++ searching
Weifang - who is a good eng contact for crostini searches? :)

Search files on "Play Files" looks working.
What missing feature do you have in mind about search?

If it's working for Play Files we should keep it enabled for this volume.

The idea is to be able to search across all volumes inside My Files, so 1 search that searches across Downloads, Play and Linux Files. But this will come in a later moment.

I see.
The current behavior of the search box for local volumes is that we search files in the current folder and its subfolders.
If we select "My Files", search files across all child volumes makes sense, once searches on all volumes get available.

fukino@ - if you use "Search" while in the "Play Files" directory, will it search the Play Files?

Yes, and if you see /Play Files/Pictures, it will search files inside /Play Files/Pictures.

Awesome. So I guess we can leave search enabled for Play Files :D

Just to confirm, though... +weifang is that sub-directory behaviour what is expected? :)

Yes, confirmed. :)

Also, +joelhockey@ for the Search behavior for the Linux Files root. Not sure what the current status of this is?

Linux Files is working the same as described for Play and Downloads.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1619616effa80c741af26164faafec7a7a86d221

commit 1619616effa80c741af26164faafec7a7a86d221
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Jul 06 03:33:26 2018

Hide search for My Files

Hide search for My Files and add tests for it.

Add test helper function selectOnDirectoryTree based on the existing
logic from selectVolume.

Bug:  848550 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibf12c2d9152723d670e25b8e2a99813a670b6c6a
Reviewed-on: https://chromium-review.googlesource.com/1126697
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572886}
[modify] https://crrev.com/1619616effa80c741af26164faafec7a7a86d221/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/1619616effa80c741af26164faafec7a7a86d221/ui/file_manager/file_manager/background/js/test_util.js
[modify] https://crrev.com/1619616effa80c741af26164faafec7a7a86d221/ui/file_manager/file_manager/foreground/js/search_controller.js
[modify] https://crrev.com/1619616effa80c741af26164faafec7a7a86d221/ui/file_manager/integration_tests/file_manager/my_files.js

I tested it with My files, Downloads and Play files.

Search is only disabled when My files is selected, it's enabled and working when Downloads and Play files are selected.

Closing this bug.