Issue metadata
Sign in to add a comment
|
window.screenX and window.screenY don't update until browser window resize
Reported by
djpe...@gmail.com,
Jun 1 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36 Steps to reproduce the problem: 1. Launch browser. 2. Open developer console. 3. Type window.screenX in developer console and press enter 4. See result in console (some number) 5. Move browser window to a new position on the screen 6. Type window.screenX in developer console and press enter 7. You will see the same number as on step 4. What is the expected behavior? On step 7 you should get new X coordinate of the browser window, since you move it. What went wrong? window coordinates doesn't update if browser window is moved. Did this work before? Yes Chrome 65 or 66. Does this work in other browsers? Yes Chrome version: 67.0.3396.62 Channel: stable OS Version: OS X 10.11.6 Flash Version: If you resize browser window - window.screenX and window.screenY will update.
,
Jun 1 2018
djpeton@ Thanks for the issue Able to reproduce this issue on Mac OS 10.13.3 on the latest Stable 67.0.3396.62 and latest Canary 69.0.3446.0 as per the original comment. Unable to reproduce the issue on Windows 10 and Ubuntu 14.04. Bisect Information: =================== Good Build: 67.0.3379.0 (Revision - 545319) Bad Build : 67.0.3381.0 (Revision - 545918) By running the per-revision bisect script, below is the Changelog URL. https://chromium.googlesource.com/chromium/src/+log/f80b81f5acef719016cd8e168a7bdd9848b9fb3a..e082cddb5ec98a6f22353ccad008d6aa6487439c From the above Changelog, suspecting the below change: Reviewed-on: https://chromium-review.googlesource.com/977229 ccameron@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner. Adding ReleaseBlock-Stable for M-67 as this is a recent regression. Please feel to remove if it is not applicable. Thanks
,
Jun 1 2018
I will take a look at this, that patch is likely the culprit... but doing a clean merge will be very hard at this point.
,
Jun 1 2018
Thank you ccameron@. Based on #3, can we leave with this bug for M67?
,
Jun 2 2018
Based on offline discussion, this should wait for 68 -- it's far too risky a change, and the API (according to the people who know about these sorts of things) has been semi-broken for a while. The fix will make the results more precise (the renderer will get updates at every move).
,
Jun 2 2018
Thank you ccameron@. Removing "M-67" & "Target-67" based on #5 and internal email thread.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2e1e82b2d9e8e318231d65adb5acf58b020031b commit c2e1e82b2d9e8e318231d65adb5acf58b020031b Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Jun 04 22:18:41 2018 mac: Send window position to renderer Send this message every time the window position changes. This was accidentally removed during refactoring to support cross-process views. Bug: 848548 Change-Id: Ide7fd5a82304dbc25b612bd1371c6cda9fa678fe Reviewed-on: https://chromium-review.googlesource.com/1085999 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#564266} [modify] https://crrev.com/c2e1e82b2d9e8e318231d65adb5acf58b020031b/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Jun 4 2018
Merge request 68
,
Jun 4 2018
Should be "Merge-Request-68" per comment #8.
,
Jun 4 2018
Just noticed that this just landed in Canary. Let's see how it looks, and then revisit merge tomorrow.
,
Jun 5 2018
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #67.0.3396.62 Verified the fix on Mac 10.13.3 using Chrome version #69.0.3450.0 as per the comment #0. Attaching screen cast for reference. Observed that window coordinates update when browser window is moved. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jun 5 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ff3f9861da095e15cd94f7c5bd43beaa268843d commit 8ff3f9861da095e15cd94f7c5bd43beaa268843d Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Jun 06 04:38:00 2018 mac: Send window position to renderer Send this message every time the window position changes. This was accidentally removed during refactoring to support cross-process views. TBR=ccameron@chromium.org (cherry picked from commit c2e1e82b2d9e8e318231d65adb5acf58b020031b) Bug: 848548 Change-Id: Ide7fd5a82304dbc25b612bd1371c6cda9fa678fe Reviewed-on: https://chromium-review.googlesource.com/1085999 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#564266} Reviewed-on: https://chromium-review.googlesource.com/1088315 Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#205} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/8ff3f9861da095e15cd94f7c5bd43beaa268843d/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Jun 6 2018
,
Jun 7 2018
Able to reproduce this issue on Mac OS 10.13.3 on the reported version 67.0.3396.62 and the issue is fixed on the latest M-68 Build 68.0.3440.17. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks.. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Jun 1 2018