New issue
Advanced search Search tips

Issue 848547 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

LUCI Scheduler Generation

Project Member Reported by dgarr...@chromium.org, Jun 1 2018

Issue description

Implement generation of the LUCI Scheduler configuration file as specified here: go/cros-gen-sched-config.
 
Cc: nxia@chromium.org dgarr...@chromium.org
 Issue 756649  has been merged into this issue.
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a6fdf12b5f6e9aae31aaf03afb7e3b1e9dba29a3

commit a6fdf12b5f6e9aae31aaf03afb7e3b1e9dba29a3
Author: Don Garrett <dgarrett@google.com>
Date: Thu Jun 07 19:23:59 2018

config_lib: Add scheduled/gitiles_triggered values.

Add two new config values that will be use to autogenerate the LUCI
Scheduler configuration file.

Add a unittest to validate they are used at least somewhat correctly.

BUG= chromium:848547 
TEST=run_tests

Change-Id: Ia004201cbec567436c8d9eead3b911d272cf675f
Reviewed-on: https://chromium-review.googlesource.com/1081872
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/a6fdf12b5f6e9aae31aaf03afb7e3b1e9dba29a3/lib/config_lib.py
[modify] https://crrev.com/a6fdf12b5f6e9aae31aaf03afb7e3b1e9dba29a3/config/chromeos_config_unittest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/840fa58f74172639927789df7428cdab5760bd3e

commit 840fa58f74172639927789df7428cdab5760bd3e
Author: Don Garrett <dgarrett@google.com>
Date: Thu Jun 07 19:29:44 2018

chromeos_config: Setup LUCI scheduler entries.

Create LUCI Scheduler configuration entries to match the current
swarming LUCI Scheduler configuration.

This won't really do anything until we start generating the LUCI
Scheduler configuration. I found a number of builders that were
assigned to the wrong waterfall and fixed them.

BUG= chromium:848547 
TEST=run_tests

Change-Id: I7677545da2f68e465abac3d9cf6ddae3924d0c77
Reviewed-on: https://chromium-review.googlesource.com/1081873
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/840fa58f74172639927789df7428cdab5760bd3e/config/chromeos_config.py
[modify] https://crrev.com/840fa58f74172639927789df7428cdab5760bd3e/config/waterfall_layout_dump.txt
[modify] https://crrev.com/840fa58f74172639927789df7428cdab5760bd3e/config/config_dump.json

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7dc7bd0654d1a3ebb5d2110a20fa16fc012d7bf

commit e7dc7bd0654d1a3ebb5d2110a20fa16fc012d7bf
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jun 07 21:36:52 2018

Roll src/third_party/chromite a206cf9..840fa58 (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a206cf9..840fa58


git log a206cf9..840fa58 --date=short --no-merges --format='%ad %ae %s'
2018-06-07 dgarrett@google.com chromeos_config: Setup LUCI scheduler entries.
2018-06-07 dgarrett@google.com config_lib: Add scheduled/gitiles_triggered values.


Created with:
  gclient setdep -r src/third_party/chromite@840fa58

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:848547 , chromium:848547 
TBR=chrome-os-gardeners@chromium.org

Change-Id: Iecd89be164aaf7ec2fb396d70a3bcda749e97d4f
Reviewed-on: https://chromium-review.googlesource.com/1091530
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565419}
[modify] https://crrev.com/e7dc7bd0654d1a3ebb5d2110a20fa16fc012d7bf/DEPS

Comment 6 by nxia@chromium.org, Jun 8 2018

Cc: -nxia@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/be3608b0ec323d151a09d47a8e6ca5430d2c9429

commit be3608b0ec323d151a09d47a8e6ca5430d2c9429
Author: Don Garrett <dgarrett@google.com>
Date: Sat Jun 09 18:41:07 2018

gen_luci_scheduler_config: Add new script.

This script can generate a new LUCI Scheduler configuration file based
on the chromeos_config. Nothing publishes this scheduler configuration
file, but it can be used manually.

BUG= chromium:848547 
TEST=run_tests + manually comparing the output with live config.

Change-Id: Ib5dae431a06fd1d5b0e8f06e150ee29307224f96
Reviewed-on: https://chromium-review.googlesource.com/1087766
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[add] https://crrev.com/be3608b0ec323d151a09d47a8e6ca5430d2c9429/scripts/gen_luci_scheduler.py
[add] https://crrev.com/be3608b0ec323d151a09d47a8e6ca5430d2c9429/scripts/gen_luci_scheduler
[add] https://crrev.com/be3608b0ec323d151a09d47a8e6ca5430d2c9429/scripts/gen_luci_scheduler_unittest
[add] https://crrev.com/be3608b0ec323d151a09d47a8e6ca5430d2c9429/scripts/gen_luci_scheduler_unittest.py

Status: Fixed (was: Started)
There is now an automated script, even if the actual updates are manual. This is enough for now, so calling it fixed.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 12 2018

Labels: merge-merged-config
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/b64ab86289bbcb7884d7c2cd2d661a75c49ab40b

commit b64ab86289bbcb7884d7c2cd2d661a75c49ab40b
Author: Don Garrett <dgarrett@google.com>
Date: Tue Jun 12 17:10:59 2018

Sign in to add a comment