Tabs: Appearance for custom themes |
||||||||||||||||||||||||||||||
Issue descriptionFor themes (and likely Windows 7), we need to decide whether to draw strokes, and if so, how the strokes work. Options include: (1) Do nothing -- no strokes, draw dividers. The dividers look bad in this case because the tab top arcs come to a "point" between the two tabs, and the the dividers are on one side of that point. Also, the clash between background tab image and frame image could look awkward in some themes without a dividing stroke. (2) Draw strokes around tabs, akin to pre-refresh. For this, we probably want to: ** Change the dividers into a special-case version of the border stroke and then always draw the stroke ** When there are full strokes, be "inside" the interior on the leading edge (as with the current divider) and "outside" on the trailing edge (so the strokes of adjacent tabs overlap instead of being side-by-side (3) Draw a flat-topped "background tab" region, likely with a stroke across the top, then draw tabs as today (dividers, no strokes) inside it My suspicion is that option (3) will look bad with the short drag handle area once bug 837014 is fixed, and I don't think (1) is polished enough to ship. So my guess is we should do (2). P2 because while it doesn't block initial dogfooding we really shouldn't ship without this.
,
Jun 7 2018
bettes@ to help decide
,
Jun 28 2018
,
Jul 12
,
Jul 26
Update on comment 0: (1) The dividers are now in the middle of the "arc", which improves the look of the dividers when tab shapes are visible. I still don't think this looks great, but it's shippable. (2) Now that we've changed how overlap works, where to draw strokes, if we did that, is more obvious. That said, I'm not quite as happy with the idea of strokes as I was. Still maybe worth playing with as a comparison point. (3) I have a crappy prototype of this. Screenshots attached: * Real shots of trunk vs. prototype for three themes with wide tabs, and one theme with narrow tabs * Mocks of win 7 glass with and without this change I think overall the change is an improvement. Code for the prototype is at https://chromium-review.googlesource.com/c/chromium/src/+/1150925 .
,
Aug 16
The desired action here at this point is for bettes@ to provide feedback on the appearance options here, in particular in light of the updates on comment 5. The scope of this bug is "all cases where background tabs are visible".
,
Aug 20
,
Aug 21
,
Aug 31
On Windows (beta) and Linux (70.0.3534.4 (Official Build) dev (64-bit)) with some themes I've been noticing that the new tab style makes it nearly impossible to distinguish the active tab from other tabs. This seems like a pretty bad issue. Let me know if I should file a separate bug.
,
Aug 31
@9: That would be bug 877741.
,
Sep 13
,
Sep 20
,
Sep 26
|
||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, Jun 1 2018Status: Assigned (was: Untriaged)