- When system spell check is turned off, remove the context menu item and settings rows for enhanced Google spell check. Also make sure that no data is being sent to Google (which should already be the case)
- When system spell check is turned on, surface the enhanced spell check setting in three places:
-- In the context menu (same way it's currently displayed)
-- In the "Languages" section of settings underneath "Spell check" (see first screenshot). This row should not have a toggle; instead, it should just link to the "Sync and Google services" section of settings (need to update mock)
-- In the "Sync and Google services" settings subpage, where it will be configurable (see second screenshot)

Note that for Mac, system spell check is always on, so only the latter half of the above spec is relevant (i.e. the enhanced spell check settings are always visible).

Deleted: Screen Shot 2018-06-05 at 11.27.16 AM.png 155 KB

	Screen Shot 2018-06-05 at 11.27.16 AM.png 155 KB View Download

Deleted: Screen Shot 2018-06-05 at 11.29.03 AM.png 682 KB

	Screen Shot 2018-06-05 at 11.29.03 AM.png 682 KB View Download

Adding Joel and Johannes (discussed with them in person today)

Adding Namrata just in case WebUI UX expertise is needed.

FYI, we've updated the spec a bit for the case where system spell check is turned OFF. We will remove the context menu item as described above, but we'll keep the rows in settings. Instead of entirely hiding them, we'll show the "Enhanced spell check" setting as disabled and OFF, and add some subtext to inform the user that they need to turn on system spell check in order to turn on "Enhanced spell check." Mocks incoming.

Also it turns out that we DO need to also disable/show as "OFF" enhanced Google spell check settings from both places on Mac too when the system spellcheck is disabled because if you toggle the system spellcheck on and off (system Edit menu -> Spelling&Grammar -> Check spelling while typing) it also disable enhanced spellcheck.
 
As discussed, language team will implement:
1) Surface a pointer to the enhanced spell check setting in Language settings (mocks to come).
2) When system spell check is turned off, remove the Enhanced spellcheck context menu item on Windows, etc. (already done on Mac).

DICE team will implement:
1) What Eli describes in c11 (in Sync and Google services settings, show the "Enhanced spell check" setting as disabled and OFF, and add some subtext to inform the user that they need to turn on system spell check in order to turn on "Enhanced spell check." Mocks incoming.)

Issue 795710 has been merged into this issue.

Issue 868418 has been merged into this issue.

Another addition: Typing "spellcheck" in chrome://settings search bar should show all spellcheck related settings, including "Ask Google for suggestions".

Settings search only finds places where the exact string appears in the UI. It can't find synonyms. See issue 692774 for Synonyms feature request.

We've renamed the feature "Enhanced spellcheck" so theoretically if users search for spellcheck both'll show up?

Issue 891558 has been merged into this issue.

Also, dpapad@ : are you or someone on your team by any chance able to help us implement proposed changes? 

https://docs.google.com/presentation/d/1Ve98Q6V96ZuqTnh-WlIe0OVFWyNXT-HguYzQW_9DkbA/edit#slide=id.g4315d7706d_0_0

@yyushkina: What is the timeframe for these changes? We've already planned for Q4  and allocated resources accordingly, so I don't think we can help with the actual implementation within Q4 (unless we get some new people which is possible).

Happy to help with reviews, guidance, or let's meet before Q1 2019 planning to see whether we could pick these up.

@mathp - could we get this staffed later this quarter do you think?