WebUI: Ensure cr-dialog 'close' and 'cancel' events are bubbling in Shadow DOM v1. |
|||
Issue descriptioncr-dialog's users currently rely on a bubbling 'close' event fired by the internal native dialog element. With Shadow DOM v1, the 'close' event is no longer bubbling. cr-dialog needs to catch that event and re-fire it with "composed: true" to make it bubbling. See more context at issue 847979 , which suggests that the change in behavior from Shadow DOM v0 to v1 is intentional.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd079f3a2a9ae6e57671a312c1875de1e5ef75c4 commit cd079f3a2a9ae6e57671a312c1875de1e5ef75c4 Author: dpapad <dpapad@chromium.org> Date: Fri Jun 01 01:47:14 2018 WebUI: Add cr-dialog tests to ensure 'close' and 'cancel' events are bubbling. This is in preparation for migrating to Polymer2, which uses Shadow DOM v1, which changed the bubbling behavior of various events to not bubble. These tests will fail in v1, without additional changes to cr-dialog itself. Bug: 848518 Change-Id: I5eb7c7c1c1c5eae325649d50952299f4d84337ef Reviewed-on: https://chromium-review.googlesource.com/1081668 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#563479} [modify] https://crrev.com/cd079f3a2a9ae6e57671a312c1875de1e5ef75c4/chrome/test/data/webui/cr_elements/cr_dialog_test.js [modify] https://crrev.com/cd079f3a2a9ae6e57671a312c1875de1e5ef75c4/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
,
Jun 1 2018
Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1083017.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f8d5a8b5528cfa0e29fb5e37f6d300fc60ee4c8 commit 2f8d5a8b5528cfa0e29fb5e37f6d300fc60ee4c8 Author: dpapad <dpapad@chromium.org> Date: Mon Jun 04 21:09:42 2018 WebUI Polymer 2 migration: Ensure 'cancel' and 'close' bubble from cr-dialog. In Shadow DOM v1, the 'cancel' and 'close' events fire from <dialog> do not bubble across shadow root boundaries (which is WAI per issue 847979 ). Need to catch and re-fire such that they do bubble. Bug: 848518 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5a9d439c5d30512a02cf18f18889b05ee809503c Reviewed-on: https://chromium-review.googlesource.com/1083017 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#564238} [modify] https://crrev.com/2f8d5a8b5528cfa0e29fb5e37f6d300fc60ee4c8/chrome/test/data/webui/cr_elements/cr_dialog_test.js [modify] https://crrev.com/2f8d5a8b5528cfa0e29fb5e37f6d300fc60ee4c8/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/2f8d5a8b5528cfa0e29fb5e37f6d300fc60ee4c8/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
Jun 4 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, May 31 2018