The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94a981bb9e1fedb98b268ffae946073bf266c6ca

commit 94a981bb9e1fedb98b268ffae946073bf266c6ca
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jul 12 21:39:52 2018

[Picture in Picture] Add controls as child views

Add PiP window controls as child views instead of layers.

This will allow a bunch of inbuilt a11y functionality
to work (e.g. screen reader and focus ring).

BUG= 848508 , 848509 

Change-Id: I78162241fca0a86999360e9316d5aa69e490021d
Reviewed-on: https://chromium-review.googlesource.com/1132546
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574733}
[modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/chrome/browser/ui/views/overlay/overlay_window_views.h
[modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/browser/picture_in_picture/overlay_surface_embedder.cc
[modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/browser/picture_in_picture/overlay_surface_embedder.h
[modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/public/browser/overlay_window.h
[modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/shell/browser/layout_test/layout_test_content_browser_client.cc

Tested with VoiceOver in OSX.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d42ff3d767609e00f2317ca61e577b461aa58646

commit d42ff3d767609e00f2317ca61e577b461aa58646
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Jul 27 21:54:13 2018

[Picture in Picture] Use ButtonHandler for controls

Use a ButtonHandler for the play/pause and close buttons so
they can be picked up by voiceover.

BUG= 848509 

Change-Id: I6fb063c03156d48b814fd3d370703724753a0b29
Reviewed-on: https://chromium-review.googlesource.com/1153623
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578821}
[modify] https://crrev.com/d42ff3d767609e00f2317ca61e577b461aa58646/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/d42ff3d767609e00f2317ca61e577b461aa58646/chrome/browser/ui/views/overlay/overlay_window_views.h

Adding merge request label for last CL

Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please merge your change to M69 branch 3497 by 2:00 PM PT Monday, 07/30, so we can pick it up for next week last M69 Dev release. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8b6f65fca9e69323128a6ea550c8ad58585864e

commit b8b6f65fca9e69323128a6ea550c8ad58585864e
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Jul 30 16:13:09 2018

[Picture in Picture] Use ButtonHandler for controls

Use a ButtonHandler for the play/pause and close buttons so
they can be picked up by voiceover.

BUG= 848509 

Change-Id: I6fb063c03156d48b814fd3d370703724753a0b29
Reviewed-on: https://chromium-review.googlesource.com/1153623
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578821}(cherry picked from commit d42ff3d767609e00f2317ca61e577b461aa58646)
Reviewed-on: https://chromium-review.googlesource.com/1155070
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#209}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/b8b6f65fca9e69323128a6ea550c8ad58585864e/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/b8b6f65fca9e69323128a6ea550c8ad58585864e/chrome/browser/ui/views/overlay/overlay_window_views.h

Able to reproduce this issue on build without fix, hence verifying the issue on latest Dev #69.0.3497.23 using Windows 10,Debian, Mac OS X.

Now, able to use PiP video controls  (i.e;play/pause & close) by voiceover using space bar.

As fix is working as expected adding Verified labels.

Thanks!

Attaching screen-cast for reference.
Thanks!

Deleted: PIP_with fix.webm 2.9 MB

	PIP_with fix.webm 2.9 MB View Download