When tabbing through the window, it should be obvious which control (e.g. play/pause, close) is focused.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/490d934b7cb54ff5ecc6bf98215f3b917b111a5d commit 490d934b7cb54ff5ecc6bf98215f3b917b111a5d Author: Jennifer Apacible <apacible@chromium.org> Date: Fri Jun 01 16:30:09 2018 [Picture in Picture] Add focus ring when buttons are focused. Currently, there is no visual indicator when the buttons are focused. Bug: 848508 Change-Id: I29f6f46835aa1d7f8e03e290c8071d3f85083446 Reviewed-on: https://chromium-review.googlesource.com/1080982 Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#563670} [modify] https://crrev.com/490d934b7cb54ff5ecc6bf98215f3b917b111a5d/chrome/browser/ui/views/overlay/overlay_window_views.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94a981bb9e1fedb98b268ffae946073bf266c6ca commit 94a981bb9e1fedb98b268ffae946073bf266c6ca Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Jul 12 21:39:52 2018 [Picture in Picture] Add controls as child views Add PiP window controls as child views instead of layers. This will allow a bunch of inbuilt a11y functionality to work (e.g. screen reader and focus ring). BUG= 848508 , 848509 Change-Id: I78162241fca0a86999360e9316d5aa69e490021d Reviewed-on: https://chromium-review.googlesource.com/1132546 Reviewed-by: apacible <apacible@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#574733} [modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/chrome/browser/ui/views/overlay/overlay_window_views.h [modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/browser/picture_in_picture/overlay_surface_embedder.cc [modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/browser/picture_in_picture/overlay_surface_embedder.h [modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/browser/web_contents/web_contents_impl_unittest.cc [modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/public/browser/overlay_window.h [modify] https://crrev.com/94a981bb9e1fedb98b268ffae946073bf266c6ca/content/shell/browser/layout_test/layout_test_content_browser_client.cc
Comment 1 by apaci...@chromium.org
, May 31 2018