The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/0eae427a1dac5d2896a388e5a94aad5b52079371

commit 0eae427a1dac5d2896a388e5a94aad5b52079371
Author: Amin Hassani <ahassani@chromium.org>
Date: Tue Jun 05 00:23:39 2018

update_engine: Fix update check error crash

In commit 6bb001ff0c2a6b0f26e50354e6a53cd37eb780d4, the return value of
AttemptUpdateWithFlags() became dependent on the out_result of AttemptUpdate()
which is wrong. This dependency causes the error pointer not be populated when
the update check is failed/ignored. And historically, failure of the update
check does not mean the failure of the dbus signal.

BUG= chromium:848486 
TEST=cros flash followed by an interactive update did not crash the update engine.

Change-Id: I440c51683bdfc9d671c38142c965466815c69f47
Reviewed-on: https://chromium-review.googlesource.com/1082979
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/0eae427a1dac5d2896a388e5a94aad5b52079371/dbus_service.cc

Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/d202a9e0926d0e92cf874e5565e30fc5c8b73a48

commit d202a9e0926d0e92cf874e5565e30fc5c8b73a48
Author: Amin Hassani <ahassani@chromium.org>
Date: Wed Jun 06 16:51:59 2018

update_engine: Fix update check error crash

In commit 6bb001ff0c2a6b0f26e50354e6a53cd37eb780d4, the return value of
AttemptUpdateWithFlags() became dependent on the out_result of AttemptUpdate()
which is wrong. This dependency causes the error pointer not be populated when
the update check is failed/ignored. And historically, failure of the update
check does not mean the failure of the dbus signal.

BUG= chromium:848486 
TEST=cros flash followed by an interactive update did not crash the update engine.

Change-Id: I440c51683bdfc9d671c38142c965466815c69f47
Reviewed-on: https://chromium-review.googlesource.com/1082979
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>
(cherry picked from commit 0eae427a1dac5d2896a388e5a94aad5b52079371)

[modify] https://crrev.com/d202a9e0926d0e92cf874e5565e30fc5c8b73a48/dbus_service.cc

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/709800cc66d3e620d7888520da6b9144a62b97b6

commit 709800cc66d3e620d7888520da6b9144a62b97b6
Author: Amin Hassani <ahassani@chromium.org>
Date: Mon Jun 11 16:56:40 2018

update_engine: Fix update check error crash

In commit 6bb001ff0c2a6b0f26e50354e6a53cd37eb780d4, the return value of
AttemptUpdateWithFlags() became dependent on the out_result of AttemptUpdate()
which is wrong. This dependency causes the error pointer not be populated when
the update check is failed/ignored. And historically, failure of the update
check does not mean the failure of the dbus signal.

BUG= chromium:848486 
TEST=cros flash followed by an interactive update did not crash the update engine.

Change-Id: I440c51683bdfc9d671c38142c965466815c69f47
Reviewed-on: https://chromium-review.googlesource.com/1082979
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>
(cherry picked from commit 0eae427a1dac5d2896a388e5a94aad5b52079371)

[modify] https://crrev.com/709800cc66d3e620d7888520da6b9144a62b97b6/dbus_service.cc

Merges Done!

Verified on Chrome OS 10718.19.0, 68.0.3440.22. Thanks!