New issue
Advanced search Search tips

Issue 848485 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug-Regression



Sign in to add a comment

Start up sound not heard at the Welcome screen.

Project Member Reported by mkarkada@chromium.org, May 31 2018

Issue description

Chrome OS: 10575.52.0, 67.0.3396.69 beta channel on coral bruce, eve devices
Chrome OS: 10739.0.0, 69.0.3445.0 dev channel eve device

Bisecting this issue from  Issue 841627 

What steps will reproduce the problem?
1. Powerwash the device and Welcome screen appears

What happens ?
Start up sound not heard at the Welcome screen.

Expected Behavior:
Welcome screen appears with a start up sound.
 

Comment 1 by wzang@chromium.org, May 31 2018

Cc: alemate@chromium.org
Unfortunate timing for stable.  Can we get this triaged ASAP with a fix/merge in as soon as today?  Anyone to add to the cc?  Really a RBS?
Cc: lpalmaro@chromium.org
Any chance this was intended? The sound here is part of our accessibility story right?
This is a bug -- after powerwash, there should be a sound that plays here to allow a blind user to know that the device is back up and running. 
Labels: -M-67 M-68
Changing from M67 > M68 RBS per group chat.  Please retag / escalate otherwise.
Any update on this? It seems like we punted from 67 but we don't have an owner.

It is marked as a R68 stable blocker and we are nearing stable in the next couple weeks, we are at risk of punting again.
Cc: abodenha@chromium.org
This bug needs to be fixed and merged back within the next week or it will start blocking our R68 stable release.
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
My initial investigation shows that deploying unstripped version of Chrome to EVE device plays sound normally.

But stripped version does not play any audio.

Looks like a race...
Owner: dgreid@chromium.org
After discussion with Dylan:

- We initialize audio subsystem only after sign-in screen is visible.
To speed-up device loading.

- This could be a regression if Intel made their device start-up slower, but we do not know for sure without testing.

- On OOBE side we could introduce some speculative delay (like 2 seconds), but we do not have any signal that audion hardware has been initialized.

Bernie, Laura, WDYT?

Assigning to Dylan.

I'd also note that this has been a problem for a long time. The oobe sound stutters or is skipped on many slower devices. Can we block startup only for oobe runs? That way we can have the boot up sound and still good boot time.
If we need to do anything about this, it needs to be done by Monday afternoon, our stable RC builds on Monday night. 

I don't have a strong opinion on the delay we use if we go down that route, as long as we stay within spec.
Cc: zalcorn@chromium.org
+Zach
Labels: -Pri-1 Pri-0
This is currently blocking the 68 stable release, we intend to build tonight, so if at all possible this should be resolved in the next few hours.

Raising priority.
Labels: -M-68
Per offline discussion, punting to 69.

Comment 17 Deleted

I can think of two possible solutions:

1. It seems that we can defer the playback like the similar situation in  issue 455938 . The difference is that in  issue 455938 , we want to defer playback until CRAS is available for connection. Here, we want to defer playback until there is active output device. With this we can hide detail from audio user.

2. Use observer to wait for output device to appear, like arc bridge [1] or tray audio[2]. CrasAudioHandler will notify observers when audio node change [3].

[1] https://cs.chromium.org/chromium/src/components/arc/audio/arc_audio_bridge.cc?type=cs&q=GetPrimaryActiveOutputNode&g=0&l=96
[2] https://cs.chromium.org/chromium/src/ash/system/audio/tray_audio.cc?type=cs&q=OnAudioNodesChanged&g=0&l=129
[3] https://cs.chromium.org/chromium/src/chromeos/audio/cras_audio_handler.cc?l=1477


Hi alemate@, do you want to put similar observer logic in OOBE ?
If not, Yuhsuan can help checking whether solution 1 is feasible.

Thanks!
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1710c99c9df8c7d299b6ce4acdfdaf88156d1a3

commit c1710c99c9df8c7d299b6ce4acdfdaf88156d1a3
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Aug 03 21:02:48 2018

Chrome OS OOBE: Play startup sound only when sound device is present.

This CL delays startup sound playback until default sound output device
has known type.

Bug:  848485 
Change-Id: I911e37afd34d28f142c46ef63b7b6345988d159b
Reviewed-on: https://chromium-review.googlesource.com/1160143
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580648}
[modify] https://crrev.com/c1710c99c9df8c7d299b6ce4acdfdaf88156d1a3/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/c1710c99c9df8c7d299b6ce4acdfdaf88156d1a3/chrome/browser/chromeos/login/ui/login_display_host_webui.h

Labels: Merge-Request-69
Status: Fixed (was: Started)
Dylan, I'll mark this fixed to request merge.
Do you think we need to do anything else here?

Project Member

Comment 22 by sheriffbot@chromium.org, Aug 4

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 24 by sheriffbot@chromium.org, Aug 13

Cc: cindyb@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec0ed3dddc8a741c087ba5072eaeba64acea183d

commit ec0ed3dddc8a741c087ba5072eaeba64acea183d
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Aug 14 08:27:42 2018

Chrome OS OOBE: Increase startup sound delay and add UMA metric.

This CL increases OOBE startup sound delay to 4 seconds, and adds UMA metric
on it.

Bug:  848485 
Change-Id: I5401a2625634315760906789fcd69afe04d2972c
Reviewed-on: https://chromium-review.googlesource.com/1173014
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582866}
[modify] https://crrev.com/ec0ed3dddc8a741c087ba5072eaeba64acea183d/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/ec0ed3dddc8a741c087ba5072eaeba64acea183d/tools/metrics/histograms/histograms.xml

Thanks for the ping after the additional CL was added, appreciated! Please continue and merge.
Project Member

Comment 27 by bugdroid1@chromium.org, Aug 15

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/356688fcb5f974309340d8de22a6d277db90fb64

commit 356688fcb5f974309340d8de22a6d277db90fb64
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 15 18:51:28 2018

Chrome OS OOBE: Play startup sound only when sound device is present.

This CL delays startup sound playback until default sound output device
has known type.

TBR=alemate@chromium.org

(cherry picked from commit c1710c99c9df8c7d299b6ce4acdfdaf88156d1a3)

Bug:  848485 
Change-Id: I911e37afd34d28f142c46ef63b7b6345988d159b
Reviewed-on: https://chromium-review.googlesource.com/1160143
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580648}
Reviewed-on: https://chromium-review.googlesource.com/1176209
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#650}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/356688fcb5f974309340d8de22a6d277db90fb64/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/356688fcb5f974309340d8de22a6d277db90fb64/chrome/browser/chromeos/login/ui/login_display_host_webui.h

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ea1140dc4b9e2b85e1e0d91ba073a095ef639f3

commit 3ea1140dc4b9e2b85e1e0d91ba073a095ef639f3
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 15 18:55:06 2018

Chrome OS OOBE: Increase startup sound delay and add UMA metric.

This CL increases OOBE startup sound delay to 4 seconds, and adds UMA metric
on it.

TBR=alemate@chromium.org

(cherry picked from commit ec0ed3dddc8a741c087ba5072eaeba64acea183d)

Bug:  848485 
Change-Id: I5401a2625634315760906789fcd69afe04d2972c
Reviewed-on: https://chromium-review.googlesource.com/1173014
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582866}
Reviewed-on: https://chromium-review.googlesource.com/1176213
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#654}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/3ea1140dc4b9e2b85e1e0d91ba073a095ef639f3/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/3ea1140dc4b9e2b85e1e0d91ba073a095ef639f3/tools/metrics/histograms/histograms.xml

Sign in to add a comment