New issue
Advanced search Search tips

Issue 848482 link

Starred by 5 users
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jun 2018
Cc:
pkasting@chromium.org
Components:
EstimatedDays: 3
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 848474
issue 848480
Blocking:
issue 822061
issue 848493



Sign in to add a comment

Tabs: Dynamic coloring for NTB icon/background tab text/dividers

Project Member Reported by pkasting@chromium.org, May 31 2018 
 Bug 848474  covers making background tabs' background colors match the window frame.

This bug covers making the new tab button icon, and (when the above bug is fixed) background tab dividers and text, readable over that color.

To do this we should hoist the behavior from Windows10CaptionButton::GetBaseColor()/OnPaintBackground():

* Start with the frame color
* If applicable, blend COLOR_BUTTON_BACKGROUND atop it (with some fiddly alpha logic)
* Use the result, blended 100% toward the opposite luma, as the base color for all these items
* Then either set alpha, blend toward the frame color, or blend back toward the (new) opposite luma, to generate the paint colors for the specific items here (since tab titles and dividers, for example, are supposed to be different shades)

Comment 1 by pkasting@chromium.org, May 31 2018

Blocking: 848493

Comment 2 by pkasting@chromium.org, Jun 1 2018

EstimatedDays: 3
Oh, another thing.  For users without custom titlebar colors, we should consider "muting" these colors slightly for inactive windows, to differentiate active/inactive windows a little.  IIRC both native windows (for the caption button glyphs) and Firefox (for those + tab titles) do something like this.

Comment 3 by pkasting@chromium.org, Jun 1 2018

Status: Assigned (was: Untriaged)

Comment 4 by robliao@chromium.org, Jun 11 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f714fb00f11006c89fba24f27f862b3ecbe13e

commit 48f714fb00f11006c89fba24f27f862b3ecbe13e
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Jun 12 19:05:41 2018

Paint the tab text and separator using colors derived from frame colors.

Bug:  848482 
Bug:  848474 
Bug:  848480 
Change-Id: Iea9528748e81529e4673a3b69f22d50135a9324d
Reviewed-on: https://chromium-review.googlesource.com/1089723
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566522}
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/frame/windows_10_caption_button.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_close_button.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_controller.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_strip_controller.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_strip_types.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/ui/gfx/color_palette.h

Comment 6 by kylixrd@chromium.org, Jun 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment