New issue
Advanced search Search tips

Issue 848474 link

Starred by 6 users
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jun 2018
Cc:
pkasting@chromium.org
Components:
EstimatedDays: 2
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 822061
issue 848482



Sign in to add a comment

Tabs: Paint background tabs with frame color

Project Member Reported by pkasting@chromium.org, May 31 2018 
Currently background tabs are painted using COLOR_BACKGROUND_TAB.  Instead they should be painted using BrowserNonClientFrameView::GetFrameColor().

One way to implement this might be to change MaybeGetDefaultColorForNewerMaterialUi() in theme_properties.cc to call this.  But that would have to be able to get at the current frame, which would be challenging.

This bug does not cover making the text in these tabs readable, just getting the right background color.

Comment 1 by pkasting@chromium.org, May 31 2018

Blocking: 848482

Comment 2 by pkasting@chromium.org, Jun 1 2018

Status: Assigned (was: Untriaged)

Comment 3 by robliao@chromium.org, Jun 11 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f714fb00f11006c89fba24f27f862b3ecbe13e

commit 48f714fb00f11006c89fba24f27f862b3ecbe13e
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Jun 12 19:05:41 2018

Paint the tab text and separator using colors derived from frame colors.

Bug:  848482 
Bug:  848474 
Bug:  848480 
Change-Id: Iea9528748e81529e4673a3b69f22d50135a9324d
Reviewed-on: https://chromium-review.googlesource.com/1089723
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566522}
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/frame/windows_10_caption_button.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_close_button.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_controller.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_strip_controller.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_strip_types.h
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/48f714fb00f11006c89fba24f27f862b3ecbe13e/ui/gfx/color_palette.h

Comment 5 by kylixrd@chromium.org, Jun 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment