New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848455 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Spacing issue with Shortcut tiles

Project Member Reported by yyushkina@chromium.org, May 31 2018

Issue description

Zach noticed an issue with spacing on the tile-enabled NTP. Notice that his email address does not truncate so it runs into the title for the next tile.
 
Screen Shot 2018-05-31 at 9.20.36 AM.png
42.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408f8691e6616048a3ac78aa6f33f05511ff94d2

commit 408f8691e6616048a3ac78aa6f33f05511ff94d2
Author: kristipark <kristipark@chromium.org>
Date: Fri Jun 01 22:18:26 2018

[LocalNTP] Fix overflow for long words

Bug:  848455 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icd2f76767996c02e48d1aa1791c2fe3f1c222ef9
Reviewed-on: https://chromium-review.googlesource.com/1080983
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563829}
[modify] https://crrev.com/408f8691e6616048a3ac78aa6f33f05511ff94d2/chrome/browser/resources/local_ntp/most_visited_single.css

Labels: Merge-Request-68
Status: Fixed (was: Assigned)
Verified this is fixed in Canary
Labels: -Merge-Request-68 Merge-Approved-68
Branch:3440
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 4 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72bc2a830ef9a1e965e1cbb5d02a14f314fc65df

commit 72bc2a830ef9a1e965e1cbb5d02a14f314fc65df
Author: kristipark <kristipark@chromium.org>
Date: Mon Jun 04 18:20:29 2018

[LocalNTP] Fix overflow for long words

Bug:  848455 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icd2f76767996c02e48d1aa1791c2fe3f1c222ef9
Reviewed-on: https://chromium-review.googlesource.com/1080983
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563829}(cherry picked from commit 408f8691e6616048a3ac78aa6f33f05511ff94d2)
Reviewed-on: https://chromium-review.googlesource.com/1085503
Cr-Commit-Position: refs/branch-heads/3440@{#145}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/72bc2a830ef9a1e965e1cbb5d02a14f314fc65df/chrome/browser/resources/local_ntp/most_visited_single.css

Sign in to add a comment