New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 848445 link

Starred by 2 users
Status: Fixed
Owner:
x...@chromium.org
Closed: Jun 2018
Cc:
█ scottchen@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup raw string used in cups_add_printer_dialog.html

Project Member Reported by dpa...@chromium.org, May 31 2018 
At [1], the string literal
"Driver not found (exact error message TBD)"

is hard-coded in the code. This line was added in 2016 (see [2]) and has not been updated since. Let's either localize that string, or remove this error message if it is never shown.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html?sq=package:chromium&g=0&l=233
[2] https://codereview.chromium.org/2333283004
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af2b7328e76036ac8239713d3eaaa22f5c04ff39

commit af2b7328e76036ac8239713d3eaaa22f5c04ff39
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Jun 04 21:42:42 2018

Cups: Clean up dead codes.

We no longer show up Manufacturer-Model-Selection dialog after the printer
setup is failed (in original design the dialog did show up, see the
original CL: https://codereview.chromium.org/2333283004/patch/220001/230004),
thus clean up this piece of codes.

Bug:  848445 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If95739ddf5fb96190c3415f92f9b73c85a65c18e
Reviewed-on: https://chromium-review.googlesource.com/1085753
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564249}
[modify] https://crrev.com/af2b7328e76036ac8239713d3eaaa22f5c04ff39/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/af2b7328e76036ac8239713d3eaaa22f5c04ff39/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js

Comment 2 by x...@chromium.org, Jun 4 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment