New issue
Advanced search Search tips

Issue 848440 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

crosvm unittest fails on amd64-generic-asan builder

Project Member Reported by rahulchaudhry@chromium.org, May 31 2018

Issue description

See example build: https://ci.chromium.org/p/chromeos/builds/b8945033862851900736

The UnitTest stage fails for chromeos-base/crosvm with "symbol lookup error: /build/amd64-generic/lib64/libminijail.so: undefined symbol: __asan_init".

 
Components: Tests Tools>ChromeOS-Toolchain
Owner: jorgelo@chromium.org
Possibly related to recent fixes for https://bugs.chromium.org/p/chromium/issues/detail?id=844615

Comment 3 by vapier@chromium.org, May 31 2018

Cc: manojgupta@chromium.org
Cc: -manojgupta@chromium.org jorgelo@chromium.org
Owner: manojgupta@chromium.org
Uhm, I think Manoj can own this since he landed the CL enabling ASan in Minijail. If I get around to repro'ing this, I'll switch it back.
Solution is to build the binaries produced by crosvm with asan. However, I tried tweaking rust ebuild but passing RUSTFLAGS="-Z sanitizer=address" didn't work since rustc errored out.

The error says: "-Z" is only supported for nightly builds. Not sure what does it mean.

It is probably easier to just disable asan on minijail builds for now since current minijail asan fails have been fixed.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/581fe595e9dd48b5174e2d0c3cd5b74397c5752e

commit 581fe595e9dd48b5174e2d0c3cd5b74397c5752e
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue Jun 05 00:23:40 2018

minijail: Temporarily mask asan use.

crosvm unit tests currently fail because they link with minijail
library but the crosvm binaries are not currently built with
address sanitizer.
This causes runtime errors like:
"symbol lookup error: /build/amd64-generic/lib64/libminijail.so: undefined symbol: __asan_init".

BUG= chromium:848440 
TEST=crosvm unit tests pass with asan.

Change-Id: I55248669b5d864e0d37610fc1fe8dcc64861bf76
Reviewed-on: https://chromium-review.googlesource.com/1085251
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/581fe595e9dd48b5174e2d0c3cd5b74397c5752e/profiles/targets/chromeos/package.use.mask

Status: Verified (was: Untriaged)
crovm tests are now passing on asan builds.

Sign in to add a comment